Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2720513006: Remove status file sections for the CPS IR. (Closed)

Created:
3 years, 9 months ago by asgerf
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Remove a line from the CPS IR section that escaped the first purge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -200 lines) Patch
M pkg/pkg.status View 1 2 2 chunks +0 lines, -61 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +1 line, -7 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/html/html.status View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +1 line, -75 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
asgerf
3 years, 9 months ago (2017-02-28 12:37:15 UTC) #2
Kevin Millikin (Google)
LGTM. You know what else we could probably remove? The flag from test.py.
3 years, 9 months ago (2017-02-28 13:36:09 UTC) #3
asgerf
Committed patchset #2 (id:20001) manually as 2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a (presubmit successful).
3 years, 9 months ago (2017-02-28 13:40:13 UTC) #5
asgerf
3 years, 9 months ago (2017-02-28 16:11:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3a7529a363104f708f506f7bc5a3a575c9d5122a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698