Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4552)

Unified Diff: chrome/browser/conflicts/module_info_win_unittest.cc

Issue 2720513005: Add InspectModule() that returns a populated ModuleInspectionResult struct (Closed)
Patch Set: Another Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/conflicts/module_info_win.cc ('k') | chrome/browser/win/enumerate_modules_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/conflicts/module_info_win_unittest.cc
diff --git a/chrome/browser/conflicts/module_info_win_unittest.cc b/chrome/browser/conflicts/module_info_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a0aa931a6b6e6db8be4c8cc26d6f2f5501d48b05
--- /dev/null
+++ b/chrome/browser/conflicts/module_info_win_unittest.cc
@@ -0,0 +1,73 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/conflicts/module_info_win.h"
+
+#include <memory>
+#include <string>
+
+#include "base/environment.h"
+#include "base/files/file_path.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+base::FilePath GetKernel32DllFilePath() {
+ std::unique_ptr<base::Environment> env = base::Environment::Create();
+ std::string sysroot;
+ EXPECT_TRUE(env->GetVar("SYSTEMROOT", &sysroot));
+
+ base::FilePath path =
+ base::FilePath::FromUTF8Unsafe(sysroot).Append(L"system32\\kernel32.dll");
+
+ return path;
+}
+
+} // namespace
+
+TEST(ModuleInfoTest, InspectModule) {
+ ModuleInfoKey module_key = {GetKernel32DllFilePath(), 0, 0, 1};
+ StringMapping path_mapping = GetEnvironmentVariablesMapping({
+ L"SystemRoot",
+ });
+
+ std::unique_ptr<ModuleInspectionResult> inspection_result =
+ InspectModule(path_mapping, module_key);
+
+ EXPECT_STREQ(L"%systemroot%\\system32\\",
+ inspection_result->location.c_str());
+ EXPECT_STREQ(L"kernel32.dll", inspection_result->basename.c_str());
+ EXPECT_STREQ(L"Microsoft\xAE Windows\xAE Operating System",
+ inspection_result->product_name.c_str());
+ EXPECT_STREQ(L"Windows NT BASE API Client DLL",
+ inspection_result->description.c_str());
+ EXPECT_FALSE(inspection_result->version.empty());
+ EXPECT_EQ(inspection_result->certificate_info.type,
+ CertificateType::CERTIFICATE_IN_CATALOG);
+ EXPECT_FALSE(inspection_result->certificate_info.path.empty());
+ EXPECT_STREQ(L"Microsoft Windows",
+ inspection_result->certificate_info.subject.c_str());
+}
+
+TEST(ModuleInfoTest, NormalizeInspectionResult) {
+ ModuleInspectionResult test_case;
+ test_case.location = L"%variable%\\PATH\\TO\\file.txt";
+ test_case.version = L"23, 32, 43, 55 win7_rtm.123456-1234";
+ test_case.certificate_info.subject = base::string16(L"signer\0", 7);
+ EXPECT_EQ(7u, test_case.certificate_info.subject.length());
+
+ ModuleInspectionResult expected;
+ expected.location = L"%variable%\\path\\to\\";
+ expected.basename = L"file.txt";
+ expected.version = L"23.32.43.55";
+ expected.certificate_info.subject = L"signer";
+
+ internal::NormalizeInspectionResult(&test_case);
+
+ EXPECT_EQ(test_case.location, expected.location);
+ EXPECT_EQ(test_case.basename, expected.basename);
+ EXPECT_EQ(test_case.version, expected.version);
+ EXPECT_EQ(test_case.certificate_info.subject,
+ expected.certificate_info.subject);
+}
« no previous file with comments | « chrome/browser/conflicts/module_info_win.cc ('k') | chrome/browser/win/enumerate_modules_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698