Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: cc/surfaces/surface_info.h

Issue 2720503008: Add cc::SurfaceInfo::is_valid() (Closed)
Patch Set: Added Log() Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/surface_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_SURFACE_INFO_H_ 5 #ifndef CC_SURFACES_SURFACE_INFO_H_
6 #define CC_SURFACES_SURFACE_INFO_H_ 6 #define CC_SURFACES_SURFACE_INFO_H_
7 7
8 #include "cc/surfaces/surface_id.h" 8 #include "cc/surfaces/surface_id.h"
9 #include "ui/gfx/geometry/size.h" 9 #include "ui/gfx/geometry/size.h"
10 10
(...skipping 11 matching lines...) Expand all
22 class SurfaceInfo { 22 class SurfaceInfo {
23 public: 23 public:
24 SurfaceInfo() = default; 24 SurfaceInfo() = default;
25 SurfaceInfo(const SurfaceId& id, 25 SurfaceInfo(const SurfaceId& id,
26 float device_scale_factor, 26 float device_scale_factor,
27 const gfx::Size& size_in_pixels) 27 const gfx::Size& size_in_pixels)
28 : id_(id), 28 : id_(id),
29 device_scale_factor_(device_scale_factor), 29 device_scale_factor_(device_scale_factor),
30 size_in_pixels_(size_in_pixels) {} 30 size_in_pixels_(size_in_pixels) {}
31 31
32 bool is_valid() const {
33 return id_.is_valid() && device_scale_factor_ != 0 &&
34 !size_in_pixels_.IsEmpty();
35 }
36
32 bool operator==(const SurfaceInfo& info) const { 37 bool operator==(const SurfaceInfo& info) const {
33 return id_ == info.id() && 38 return id_ == info.id() &&
34 device_scale_factor_ == info.device_scale_factor() && 39 device_scale_factor_ == info.device_scale_factor() &&
35 size_in_pixels_ == info.size_in_pixels(); 40 size_in_pixels_ == info.size_in_pixels();
36 } 41 }
37 42
38 bool operator!=(const SurfaceInfo& info) const { return !(*this == info); } 43 bool operator!=(const SurfaceInfo& info) const { return !(*this == info); }
39 44
40 const SurfaceId& id() const { return id_; } 45 const SurfaceId& id() const { return id_; }
41 float device_scale_factor() const { return device_scale_factor_; } 46 float device_scale_factor() const { return device_scale_factor_; }
42 const gfx::Size& size_in_pixels() const { return size_in_pixels_; } 47 const gfx::Size& size_in_pixels() const { return size_in_pixels_; }
43 48
44 private: 49 private:
45 friend struct mojo::StructTraits<mojom::SurfaceInfoDataView, SurfaceInfo>; 50 friend struct mojo::StructTraits<mojom::SurfaceInfoDataView, SurfaceInfo>;
46 friend struct IPC::ParamTraits<SurfaceInfo>; 51 friend struct IPC::ParamTraits<SurfaceInfo>;
47 52
48 SurfaceId id_; 53 SurfaceId id_;
49 float device_scale_factor_ = 1.f; 54 float device_scale_factor_ = 1.f;
50 gfx::Size size_in_pixels_; 55 gfx::Size size_in_pixels_;
51 }; 56 };
52 57
53 } // namespace cc 58 } // namespace cc
54 59
55 #endif // CC_SURFACES_SURFACE_INFO_H_ 60 #endif // CC_SURFACES_SURFACE_INFO_H_
OLDNEW
« no previous file with comments | « cc/layers/surface_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698