Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary_item.js

Issue 2720503006: MD Settings: Internet: Move network lists to a subpage (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_summary_item.js
diff --git a/chrome/browser/resources/settings/internet_page/network_summary_item.js b/chrome/browser/resources/settings/internet_page/network_summary_item.js
index a478660a30d6332ffcbc2e1fa4aedf86487afe78..757487cba466e50a78f2598c2475e50f044fd7b8 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary_item.js
+++ b/chrome/browser/resources/settings/internet_page/network_summary_item.js
@@ -20,10 +20,7 @@ Polymer({
* Device state for the network type.
* @type {!DeviceStateProperties|undefined}
*/
- deviceState: {
- type: Object,
- observer: 'deviceStateChanged_',
- },
+ deviceState: Object,
/**
* Network state for the active network.
@@ -43,98 +40,10 @@ Polymer({
},
/**
- * Type of networks in networkStateList. Used to initialte scanning.
- * @type {CrOnc.Type}
- */
- networkType: String,
-
- /**
* Interface for networkingPrivate calls, passed from internet_page.
* @type {!NetworkingPrivate}
*/
networkingPrivate: Object,
-
- /**
- * The expanded state of the list of networks.
- * @private
- */
- expanded_: {
- type: Boolean,
- value: false,
- observer: 'expandedChanged_',
- },
-
- /**
- * Whether the list has been expanded. This is used to ensure the
- * iron-collapse section animates correctly.
- * @private
- */
- wasExpanded_: {
- type: Boolean,
- value: false,
- },
- },
-
- observers: ['updateScanning_(networkingPrivate, networkType, expanded_)'],
-
- /** @private {number|null} */
- scanIntervalId_: null,
-
- /** override */
- detached: function() {
- if (this.scanIntervalId_ !== null) {
- window.clearInterval(this.scanIntervalId_);
- this.scanIntervalId_ = null;
- }
- },
-
- /** @private */
- expandedChanged_: function() {
- var type = this.deviceState ? this.deviceState.Type : '';
- this.fire('expanded', {expanded: this.expanded_, type: type});
- },
-
- /** @private */
- deviceStateChanged_: function() {
- if (this.expanded_ && !this.deviceIsEnabled_(this.deviceState))
- this.expanded_ = false;
- },
-
- /** @private */
- updateScanning_: function() {
- if (this.scanIntervalId_ != null) {
- if (!this.expanded_) {
- window.clearInterval(this.scanIntervalId_);
- this.scanIntervalId_ = null;
- }
- return;
- }
- if (!this.expanded_ ||
- (this.networkType != CrOnc.Type.ALL &&
- this.networkType != CrOnc.Type.WI_FI)) {
- return;
- }
- /** @const */ var INTERVAL_MS = 10 * 1000;
- this.networkingPrivate.requestNetworkScan();
- this.scanIntervalId_ = window.setInterval(function() {
- this.networkingPrivate.requestNetworkScan();
- }.bind(this), INTERVAL_MS);
- },
-
- /**
- * @return {boolean} Whether or not the scanning spinner should be visible.
- * @private
- */
- scanningIsVisible_: function() {
- return this.deviceState.Type == CrOnc.Type.WI_FI;
- },
-
- /**
- * @return {boolean} Whether or not the scanning spinner should be active.
- * @private
- */
- scanningIsActive_: function() {
- return !!this.expanded_ && !!this.deviceState.Scanning;
},
/**
@@ -186,35 +95,6 @@ Polymer({
},
/**
- * @return {boolean} Whether the dom-if for the network list should be true.
- * The logic here is designed to allow the enclosed content to be stamped
- * before it is expanded.
- * @private
- */
- networksDomIfIsTrue_: function() {
- if (this.expanded_ == this.wasExpanded_)
- return this.expanded_;
- if (this.expanded_) {
- Polymer.RenderStatus.afterNextRender(this, function() {
- this.wasExpanded_ = true;
- }.bind(this));
- return true;
- }
- return this.wasExpanded_;
- },
-
- /**
- * @param {boolean} expanded
- * @param {boolean} wasExpanded
- * @return {boolean} Whether the iron-collapse for the network list should
- * be opened.
- * @private
- */
- networksIronCollapseIsOpened_: function(expanded, wasExpanded) {
- return expanded && wasExpanded;
- },
-
- /**
* @param {!DeviceStateProperties} deviceState
* @return {boolean}
* @private
@@ -255,55 +135,23 @@ Polymer({
},
/**
- * @return {boolean} Whether or not to show the UI to expand the list.
- * @private
- */
- expandIsVisible_: function() {
- if (!this.deviceIsEnabled_(this.deviceState))
- return false;
- var type = this.deviceState.Type;
- var minLength =
- (type == CrOnc.Type.WI_FI || type == CrOnc.Type.VPN) ? 1 : 2;
- return this.networkStateList.length >= minLength;
- },
-
- /**
- * @return {boolean} Whether or not to show the UI to show details.
+ * @return {boolean}
* @private
*/
showDetailsIsVisible_: function() {
- if (this.expandIsVisible_())
- return false;
return this.deviceIsEnabled_(this.deviceState);
},
/**
- * @param {!CrOnc.NetworkStateProperties} activeNetworkState
- * @return {boolean} True if the known networks button should be shown.
- * @private
- */
- knownNetworksIsVisible_: function(activeNetworkState) {
- return !!activeNetworkState && activeNetworkState.Type == CrOnc.Type.WI_FI;
- },
-
- /**
- * Event triggered when the details div is tapped or Enter is pressed.
- * @param {!Event} event The enable button event.
+ * @return {boolean}
* @private
*/
- onDetailsTap_: function(event) {
- if ((event.target && event.target.id == 'expandListButton') ||
- (this.deviceState && !this.deviceIsEnabled_(this.deviceState))) {
- // Already handled or disabled, do nothing.
- return;
- }
- if (this.expandIsVisible_()) {
- // Expandable, toggle expand.
- this.expanded_ = !this.expanded_;
- return;
- }
- // Not expandable, fire 'selected' with |activeNetworkState|.
- this.fire('selected', this.activeNetworkState);
+ shouldShowList_: function() {
+ var minlen = (this.deviceState.Type == CrOnc.Type.WI_FI ||
+ this.deviceState.Type == CrOnc.Type.VPN) ?
+ 1 :
+ 2;
+ return this.networkStateList.length >= minlen;
},
/**
@@ -311,18 +159,28 @@ Polymer({
* @private
*/
onShowDetailsTap_: function(event) {
- if (!this.activeNetworkState.GUID)
- return;
- this.fire('show-detail', this.activeNetworkState);
+ if (this.shouldShowList_())
+ this.fire('show-networks', this.deviceState);
+ else if (this.activeNetworkState.GUID)
+ this.fire('show-detail', this.activeNetworkState);
+ else if (this.networkStateList.length > 0)
+ this.fire('show-detail', this.networkStateList[0]);
event.stopPropagation();
},
/**
- * Event triggered when the known networks button is tapped.
+ * @return {string}
* @private
*/
- onKnownNetworksTap_: function() {
- this.fire('show-known-networks', {type: CrOnc.Type.WI_FI});
+ getDetailsA11yString_: function() {
+ if (!this.shouldShowList_()) {
+ if (this.activeNetworkState.GUID) {
+ return CrOnc.getNetworkName(this.activeNetworkState);
+ } else if (this.networkStateList.length > 0) {
+ return CrOnc.getNetworkName(this.networkStateList[0]);
+ }
+ }
+ return this.i18n('OncType' + this.deviceState.Type);
},
/**
« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_summary_item.html ('k') | chrome/browser/resources/settings/route.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698