MD Settings: Internet: Move network lists to a subpage

chrome/test/data/webui/settings/fake_networking_private.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Fake implementation of chrome.networkingPrivate for testing.
  */
 cr.define('settings', function() {
   /**
    * @constructor
@@ skipping 54 matching lines @@
     setProperties: assertNotReached,
 
     /** @override */
     createNetwork: assertNotReached,
 
     /** @override */
     forgetNetwork: assertNotReached,
 
     /** @override */
     getNetworks: function(filter, callback) {
-      callback(this.networkStates_);
+      var states = [];

[michaelpg, 2017/03/01 23:27:59]

opt nit: It's just a style thing, but this.networkStates_.filter() would fit
well here.

[stevenjb, 2017/03/02 00:25:17]

One of these days I'll learn these crazy Javascripty ways. Done.

+      var type = filter.networkType;
+      for (var i = 0; i < this.networkStates_.length; ++i) {
+        var state = this.networkStates_[i];
+        if (type == chrome.networkingPrivate.NetworkType.ALL ||
+            type == state.Type) {
+          states.push(state);
+        }
+      }
+      callback(states);
     },
 
     /** @override */
     getDeviceStates: function(callback) {
       var devices = [];
       Object.keys(this.deviceStates_).forEach(function(type) {
         var state = this.deviceStates_[type];
         if (state.State != '')
           devices.push(state);
       }.bind(this));
@@ skipping 61 matching lines @@
 
     /** @type {!FakeChromeEvent} */
     onDeviceStateListChanged: new FakeChromeEvent(),
 
     /** @type {!FakeChromeEvent} */
     onPortalDetectionCompleted: new FakeChromeEvent(),
   };
 
   return {FakeNetworkingPrivate: FakeNetworkingPrivate};
 });