Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2720493002: cleanup --batch-mode sourceFiles (Closed)

Created:
3 years, 10 months ago by danrubel
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup --batch-mode sourceFiles BuildMode, the dartanalyzer driver used when the "--build-mode" option is supplied, expects sourceFiles in the format "<uri>|<filepath>", but the rest of the dartanalyzer code base does not understand this format. This change updates BuildMode to rewrite sourceFiles, stripping the "<uri>|" prefix, so that it does not cause problems with code that does not expect this format. Fix https://github.com/dart-lang/sdk/issues/28889 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/37a6a497449bc914ad0e4ca7ecc3aad40745dace

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : mark driver_test as passing on windows #

Patch Set 4 : merge #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/pkg.status View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
danrubel
3 years, 10 months ago (2017-02-25 12:57:42 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-25 15:53:18 UTC) #5
danrubel
3 years, 9 months ago (2017-02-26 16:55:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
37a6a497449bc914ad0e4ca7ecc3aad40745dace (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698