third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html - Issue 2720463002: Remove webkitdropzone.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html

Issue 2720463002: Remove webkitdropzone. (Closed)

Patch Set: Finished rewriting dropzone tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-file.html » ('j') | third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset="utf-8" />
	jsbell 2017/03/02 22:06:45 nit: no /> just > unless this is XHTML (which it i nit: no /> just > unless this is XHTML (which it is not) pwnall 2017/03/02 22:34:29 Done. Show quoted text On 2017/03/02 22:06:45, jsbell wrote: > nit: no /> just > unless this is XHTML (which it is not) Done.
	3 <title>Drag and Drop: interaction between effectAllowed and dropEffect</title>

	4 <link rel="help" href="https://html.spec.whatwg.org/multipage/interaction.html#d rag-and-drop-processing-model">

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="resources/dropEffect-common.js"></script>

	8 <style>

	9 .box {

	10 display: block;

	11 border: 1px solid black;

	12 width: 100px;

	13 height: 100px;

	14 }

	15 </style>

	16

	17 <p>

	18 Please drag the "Drag Me" box into the "Drop Here" box repeatedly, until the

	19 test ends.

	20 </p>

	21

	22 <div class="dragged box" draggable="true">

	23 Drag Me

	24 </div>

	25

	26 <div class="dropzone box">

	27 Drop Here

	28 </div>

	29

	30 <p>

	31 Current test: <code class="test-description"></code>
	jsbell 2017/03/02 22:06:45 nit: Weird to use a class rather than an id for a nit: Weird to use a class rather than an id for a singleton. pwnall 2017/03/02 22:34:29 Done. Show quoted text On 2017/03/02 22:06:45, jsbell wrote: > nit: Weird to use a class rather than an id for a singleton. Done.
	32 </p>

	33

	34 <script>

	35

	36 dropEffectTest({ allowed: 'uninitialized', drop: 'copy', operation: 'copy' });

	37 dropEffectTest({ allowed: 'copy', drop: 'copy', operation: 'copy' });

	38 dropEffectTest({ allowed: 'copyLink', drop: 'copy', operation: 'copy' });

	39 dropEffectTest({ allowed: 'copyMove', drop: 'copy', operation: 'copy' });

	40 dropEffectTest({ allowed: 'link', drop: 'copy' });

	41 dropEffectTest({ allowed: 'linkMove', drop: 'copy' });

	42 dropEffectTest({ allowed: 'move', drop: 'copy' });

	43 dropEffectTest({ allowed: 'all', drop: 'copy', operation: 'copy' });

	44 dropEffectTest({ allowed: 'none', drop: 'copy' });

	45 dropEffectTest({ allowed: 'dummy', drop: 'copy', operation: 'copy' });

	46 dropEffectTest({ drop: 'copy', operation: 'copy' });

	47

	48 dropEffectTest({ allowed: 'uninitialized', drop: 'link', operation: 'link' });

	49 dropEffectTest({ allowed: 'copy', drop: 'link' });

	50 dropEffectTest({ allowed: 'copyLink', drop: 'link', operation: 'link' });

	51 dropEffectTest({ allowed: 'copyMove', drop: 'link' });

	52 dropEffectTest({ allowed: 'link', drop: 'link', operation: 'link' });

	53 dropEffectTest({ allowed: 'linkMove', drop: 'link', operation: 'link' });

	54 dropEffectTest({ allowed: 'move', drop: 'link' });

	55 dropEffectTest({ allowed: 'all', drop: 'link', operation: 'link' });

	56 dropEffectTest({ allowed: 'none', drop: 'link' });

	57 dropEffectTest({ allowed: 'dummy', drop: 'link', operation: 'link' });

	58 dropEffectTest({ drop: 'link', operation: 'link' });

	59

	60 dropEffectTest({ allowed: 'uninitialized', drop: 'move', operation: 'move' });

	61 dropEffectTest({ allowed: 'copy', drop: 'move' });

	62 dropEffectTest({ allowed: 'copyLink', drop: 'move' });

	63 dropEffectTest({ allowed: 'copyMove', drop: 'move', operation: 'move' });

	64 dropEffectTest({ allowed: 'link', drop: 'move' });

	65 dropEffectTest({ allowed: 'linkMove', drop: 'move', operation: 'move' });

	66 dropEffectTest({ allowed: 'move', drop: 'move', operation: 'move' });

	67 dropEffectTest({ allowed: 'all', drop: 'move', operation: 'move' });

	68 dropEffectTest({ allowed: 'none', drop: 'move' });

	69 dropEffectTest({ allowed: 'dummy', drop: 'move', operation: 'move' });

	70 dropEffectTest({ drop: 'move', operation: 'move' });

	71

	72 dropEffectTest({ allowed: 'uninitialized', drop: 'none' });
	dcheng 2017/03/02 19:24:33 I'm not quite sure how to map this to the results I'm not quite sure how to map this to the results of dropzone-001.html. From that test's expected file: When effectAllowed == "uninitialized" Received drop event for allowedEffect uninitialized and chosenDropEffect none As far as I can tell, this maps to this line, but it seems like the expected results are different. Is that expected, or am I misreading? pwnall 2017/03/02 19:57:54 The results are different because "dropzone" does Show quoted text On 2017/03/02 19:24:33, dcheng wrote: > I'm not quite sure how to map this to the results of dropzone-001.html. > > From that test's expected file: > When effectAllowed == "uninitialized" > > Received drop event for allowedEffect uninitialized and chosenDropEffect none > > As far as I can tell, this maps to this line, but it seems like the expected > results are different. Is that expected, or am I misreading? The results are different because "dropzone" does not recognize "none" as a token [1], so "none" gets treated exactly the same was as "dummy", whereas "dropEffect" does change when you assign "none" to it [2]. Isn't it great that we're killing this confusing attribute? :D [1] https://html.spec.whatwg.org/multipage/interaction.html#the-dropzone-attribute [2] https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransfer-drop...
	73 dropEffectTest({ allowed: 'copy', drop: 'none' });

	74 dropEffectTest({ allowed: 'copyLink', drop: 'none' });

	75 dropEffectTest({ allowed: 'copyMove', drop: 'none' });

	76 dropEffectTest({ allowed: 'link', drop: 'none' });

	77 dropEffectTest({ allowed: 'linkMove', drop: 'none' });

	78 dropEffectTest({ allowed: 'move', drop: 'none' });

	79 dropEffectTest({ allowed: 'all', drop: 'none' });

	80 dropEffectTest({ allowed: 'none', drop: 'none' });

	81 dropEffectTest({ allowed: 'dummy', drop: 'none' });

	82 dropEffectTest({ drop: 'none' });

	83

	84 dropEffectTest({ allowed: 'uninitialized', drop: 'dummy', operation: 'copy' });

	85 dropEffectTest({ allowed: 'copy', drop: 'dummy', operation: 'copy' });

	86 dropEffectTest({ allowed: 'copyLink', drop: 'dummy', operation: 'copy' });

	87 dropEffectTest({ allowed: 'copyMove', drop: 'dummy', operation: 'move' });

	88 dropEffectTest({ allowed: 'link', drop: 'dummy', operation: 'link' });

	89 dropEffectTest({ allowed: 'linkMove', drop: 'dummy', operation: 'move' });

	90 dropEffectTest({ allowed: 'move', drop: 'dummy', operation: 'move' });

	91 dropEffectTest({ allowed: 'all', drop: 'dummy', operation: 'copy' });

	92 dropEffectTest({ allowed: 'none', drop: 'dummy' });

	93 dropEffectTest({ allowed: 'dummy', drop: 'dummy', operation: 'copy' });

	94 dropEffectTest({ drop: 'dummy', operation: 'copy' });

	95

	96 promise_test(t => {
	jsbell 2017/03/02 22:06:45 Since this pattern repeats across the test files, Since this pattern repeats across the test files, what do you think about wrapping this up as: dropEffectTests([ { allowed: ..., drop: ..., operation: ... }, { allowed: ..., drop: ..., operation: ... }, { allowed: ..., drop: ..., operation: ... }, ... ]); ... which calls dropEffectTest for each entry and then the 'all tests complete' logic? pwnall 2017/03/02 22:34:29 Done. Show quoted text On 2017/03/02 22:06:45, jsbell wrote: > Since this pattern repeats across the test files, what do you think about > wrapping this up as: > > dropEffectTests([ > { allowed: ..., drop: ..., operation: ... }, > { allowed: ..., drop: ..., operation: ... }, > { allowed: ..., drop: ..., operation: ... }, > ... > ]); > > ... which calls dropEffectTest for each entry and then the 'all tests complete' > logic? > Done.
	97 return Promise.resolve().then(() => {

	98 document.querySelector('.test-description').textContent = 'done';

	99 });

	100 }, 'all tests complete');

	101

	102 </script>

OLD	NEW