Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 272043003: Renamed MediaStreamDependencyFactory to PeerConnectionDependencyFactory. (Closed)

Created:
6 years, 7 months ago by perkj_chrome
Modified:
6 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, fischman+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Renamed MediaStreamDependencyFactory to PeerConnectionDependencyFactory. PeerConnectionDependencyFactory should only deal with MediaStream tracks that are sent on a PeerConnection and thus is not a general MediaStream factory. This cl also moves PeerconnectionDependencyFactory to media/webrtc since it depends on libjingle/webrtc files. Note that PeerConnectionDependencyFactory still have some methods related to general audio input that should be further refactored. BUG=323223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270977

Patch Set 1 #

Patch Set 2 : media_stream_dependency_factory_unittest.cc #

Total comments: 1

Patch Set 3 : Fixed nits. #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -1856 lines) Patch
M content/content_renderer.gypi View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_source.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_center.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_center.cc View 1 2 6 chunks +5 lines, -6 lines 0 comments Download
D content/renderer/media/media_stream_dependency_factory.h View 1 chunk +0 lines, -218 lines 0 comments Download
D content/renderer/media/media_stream_dependency_factory.cc View 1 2 3 1 chunk +0 lines, -669 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory_unittest.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 4 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/media/mock_media_stream_dependency_factory.h View 1 chunk +0 lines, -232 lines 0 comments Download
D content/renderer/media/mock_media_stream_dependency_factory.cc View 1 chunk +0 lines, -541 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/remote_media_stream_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 3 chunks +11 lines, -9 lines 0 comments Download
A + content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 10 chunks +16 lines, -16 lines 0 comments Download
A + content/renderer/media/webrtc/peer_connection_dependency_factory.h View 3 chunks +8 lines, -12 lines 0 comments Download
A + content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 3 24 chunks +42 lines, -40 lines 0 comments Download
A + content/renderer/media/webrtc/peer_connection_dependency_factory_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_track_adapter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
perkj_chrome
xians- can you review?
6 years, 7 months ago (2014-05-15 06:46:13 UTC) #1
no longer working on chromium
lgtm with one nit. https://codereview.chromium.org/272043003/diff/20001/content/renderer/media/rtc_peer_connection_handler.cc File content/renderer/media/rtc_peer_connection_handler.cc (right): https://codereview.chromium.org/272043003/diff/20001/content/renderer/media/rtc_peer_connection_handler.cc#newcode29 content/renderer/media/rtc_peer_connection_handler.cc:29: #include "content/renderer/render_thread_impl.h" nit, add include ...
6 years, 7 months ago (2014-05-15 08:17:21 UTC) #2
perkj_chrome
jochen - would you mind helping me with the files outside content/renderer/media?
6 years, 7 months ago (2014-05-15 08:20:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-15 10:00:44 UTC) #4
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 7 months ago (2014-05-15 12:16:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/272043003/40001
6 years, 7 months ago (2014-05-15 12:16:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 14:15:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 18:08:53 UTC) #8
commit-bot: I haz the power
Failed to apply patch for content/content_renderer.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-15 18:08:54 UTC) #9
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 7 months ago (2014-05-16 06:25:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/272043003/60001
6 years, 7 months ago (2014-05-16 06:25:59 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 08:38:23 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 10:20:40 UTC) #13
Message was sent while issue was closed.
Change committed as 270977

Powered by Google App Engine
This is Rietveld 408576698