Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/sync_driver/sync_api_component_factory.h

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/sync_api_component_factory.h
diff --git a/components/sync_driver/sync_api_component_factory.h b/components/sync_driver/sync_api_component_factory.h
index cdb5a42db5e0cbe473741bf9125cba40809aa79c..cb543659f925f0e0fdac8cb2f163ab7315e4b661 100644
--- a/components/sync_driver/sync_api_component_factory.h
+++ b/components/sync_driver/sync_api_component_factory.h
@@ -7,7 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
-#include "sync/api/attachments/attachment_store.h"
+#include "sync/api/attachments/attachment_service.h"
#include "sync/api/syncable_service.h"
#include "sync/internal_api/public/base/model_type.h"
@@ -17,17 +17,22 @@ namespace browser_sync {
// service (like SyncableService) implementations.
class SyncApiComponentFactory {
public:
+ virtual ~SyncApiComponentFactory() {}
+
// Returns a weak pointer to the syncable service specified by |type|.
// Weak pointer may be unset if service is already destroyed.
// Note: Should only be called from the model type thread.
virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
syncer::ModelType type) = 0;
- // Returns the custom attachment store for a model type, if there is one.
- // May return NULL, which implies sync should use a default implementation.
+ // Creates attachment service.
// Note: Should only be called from the model type thread.
- virtual scoped_ptr<syncer::AttachmentStore>
- CreateCustomAttachmentStoreForType(syncer::ModelType type) = 0;
+ // |delegate| is optional delegate for AttachmentService to notify about
+ // asynchronous events (AttachmentUploaded). Pass NULL if delegate is not
+ // provided. AttachmentService doesn't take ownership of delegate, the pointer
+ // must be valid throughout AttachmentService lifetime.
+ virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService(
+ syncer::AttachmentService::Delegate* delegate) = 0;
};
} // namespace browser_sync
« no previous file with comments | « components/sync_driver/generic_change_processor_unittest.cc ('k') | sync/api/attachments/attachment_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698