Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: components/sync_driver/generic_change_processor_factory.h

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/generic_change_processor_factory.h
diff --git a/components/sync_driver/generic_change_processor_factory.h b/components/sync_driver/generic_change_processor_factory.h
index 978d313f9834eee8f59e71942c3b5efe8112c6df..ce19b22c2093e414e85fc61f7d20427c3bb15953 100644
--- a/components/sync_driver/generic_change_processor_factory.h
+++ b/components/sync_driver/generic_change_processor_factory.h
@@ -18,6 +18,7 @@ namespace browser_sync {
class DataTypeErrorHandler;
class GenericChangeProcessor;
+class SyncApiComponentFactory;
// Because GenericChangeProcessors are created and used only from the model
// thread, their lifetime is strictly shorter than other components like
@@ -26,6 +27,8 @@ class GenericChangeProcessor;
// The GCP is created "on the fly" at just the right time, on just the right
// thread. Given that, we use a factory to instantiate GenericChangeProcessors
// so that tests can choose to use a fake processor (i.e instead of injection).
+// |sync_factory| is used to create AttachmentServicefor GenericChangeProcessor.
+// It is not retained after CreateGenericChangeProcessor exits.
class GenericChangeProcessorFactory {
public:
GenericChangeProcessorFactory();
@@ -35,7 +38,8 @@ class GenericChangeProcessorFactory {
browser_sync::DataTypeErrorHandler* error_handler,
const base::WeakPtr<syncer::SyncableService>& local_service,
const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
- scoped_ptr<syncer::AttachmentService> attachment_service);
+ SyncApiComponentFactory* sync_factory);
+
private:
DISALLOW_COPY_AND_ASSIGN(GenericChangeProcessorFactory);
};
« no previous file with comments | « components/sync_driver/generic_change_processor.cc ('k') | components/sync_driver/generic_change_processor_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698