Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index 96ba91e29d815fd7da4ffc1a5990362dfaf38810..b16a492db4f97d0d236deeee5927fa24c3817a57 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -59,8 +59,10 @@
#include "content/public/browser/browser_thread.h"
#include "extensions/browser/extension_system.h"
#include "sync/api/attachments/attachment_service.h"
+#include "sync/api/attachments/attachment_service_impl.h"
#include "sync/api/syncable_service.h"
#include "sync/internal_api/public/attachments/fake_attachment_store.h"
+#include "sync/internal_api/public/attachments/fake_attachment_uploader.h"
#if defined(ENABLE_EXTENSIONS)
#include "chrome/browser/extensions/api/storage/settings_sync_util.h"
@@ -564,13 +566,24 @@ base::WeakPtr<syncer::SyncableService> ProfileSyncComponentsFactoryImpl::
}
}
-scoped_ptr<syncer::AttachmentStore>
- ProfileSyncComponentsFactoryImpl::CreateCustomAttachmentStoreForType(
- syncer::ModelType type) {
- scoped_ptr<syncer::AttachmentStore> store(
+scoped_ptr<syncer::AttachmentService>
+ProfileSyncComponentsFactoryImpl::CreateAttachmentService(
+ syncer::AttachmentService::Delegate* delegate) {
+ // TODO(maniscalco): Use a shared (one per profile) thread-safe instance of
+ // AttachmentUpload instead of creating a new one per AttachmentService (bug
+ // 369536).
+ scoped_ptr<syncer::AttachmentUploader> attachment_uploader(
+ new syncer::FakeAttachmentUploader);
+
+ scoped_ptr<syncer::AttachmentStore> attachment_store(
new syncer::FakeAttachmentStore(
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
- return store.Pass();
+
+ scoped_ptr<syncer::AttachmentService> attachment_service(
+ new syncer::AttachmentServiceImpl(
+ attachment_store.Pass(), attachment_uploader.Pass(), delegate));
+
+ return attachment_service.Pass();
}
ProfileSyncComponentsFactory::SyncComponents
« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory_impl.h ('k') | chrome/browser/sync/profile_sync_components_factory_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698