Invoke AttachmentUploader and update AttachmentIds.

components/sync_driver/generic_change_processor.h

Index: components/sync_driver/generic_change_processor.h
diff --git a/components/sync_driver/generic_change_processor.h b/components/sync_driver/generic_change_processor.h
index 9f55a53a8ee6c45e5aedcbf394a6b6b98a3912b5..90f112e74c6ac081e4a270fcd92591c27a3e979a 100644
--- a/components/sync_driver/generic_change_processor.h
+++ b/components/sync_driver/generic_change_processor.h
@@ -28,6 +28,7 @@ typedef std::vector<syncer::SyncData> SyncDataList;
 }  // namespace syncer
 
 namespace browser_sync {
+class SyncApiComponentFactory;
 
 // Datatype agnostic change processor. One instance of GenericChangeProcessor
 // is created for each datatype and lives on the datatype's thread. It then
@@ -39,6 +40,7 @@ namespace browser_sync {
 // be used on the same thread in which it was created.
 class GenericChangeProcessor : public ChangeProcessor,
                                public syncer::SyncChangeProcessor,
+                               public syncer::AttachmentService::Delegate,
                                public base::NonThreadSafe {
  public:
   // Create a change processor and connect it to the syncer.
@@ -47,7 +49,7 @@ class GenericChangeProcessor : public ChangeProcessor,
       const base::WeakPtr<syncer::SyncableService>& local_service,
       const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
       syncer::UserShare* user_share,
-      scoped_ptr<syncer::AttachmentService> attachment_service);
+      SyncApiComponentFactory* sync_factory);

[pavely, 2014/05/15 19:26:52]

The problem with this approach is that now FakeGenericChangeProcessor depends on
some SyncApiComponentFactory and cannot be initialized without it.

[maniscalco, 2014/05/15 20:09:28]

I think I see what you mean.  Creating a mock SyncApiComponentsFactory for use
in tests doesn't seem too bad to me.  Overall, I like this approach a lot better
that the setter approach.

On 2014/05/15 19:26:52, pavely wrote:

   virtual ~GenericChangeProcessor();
 
   // ChangeProcessor interface.
@@ -71,6 +73,10 @@ class GenericChangeProcessor : public ChangeProcessor,
       syncer::SyncChangeProcessor::ContextRefreshStatus refresh_status,
       const std::string& context) OVERRIDE;
 
+  // syncer::AttachmentService::Delegate implementation.
+  virtual void OnAttachmentUploaded(
+      const syncer::AttachmentId& attachment_id) OVERRIDE;
+
   // Similar to above, but returns a SyncError for use by direct clients
   // of GenericChangeProcessor that may need more error visibility.
   virtual syncer::SyncError GetAllSyncDataReturnError(