Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: sync/syncable/mutable_entry.h

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/syncable/mutable_entry.h
diff --git a/sync/syncable/mutable_entry.h b/sync/syncable/mutable_entry.h
index c064358082ec274331cc2bde4fcb36c6de12a7b5..268dfc8a0a2e4f07dce78e5cb4655b3a19893f8d 100644
--- a/sync/syncable/mutable_entry.h
+++ b/sync/syncable/mutable_entry.h
@@ -61,6 +61,9 @@ class SYNC_EXPORT_PRIVATE MutableEntry : public ModelNeutralMutableEntry {
void PutAttachmentMetadata(
const sync_pb::AttachmentMetadata& attachment_metadata);
+ // Update attachment metadata, replace all records matching attachment id's
maniscalco 2014/05/09 18:12:11 nit: there should be a blank line above this comme
pavely 2014/05/13 23:06:44 Done.
+ // unique id with updated attachment id.
+ void UpdateAttachmentId(const sync_pb::AttachmentIdProto& attachment_id);
maniscalco 2014/05/09 18:12:11 Consider renaming attachment_id to updated_attachm
pavely 2014/05/13 23:06:44 Done.
private:
// Kind of redundant. We should reduce the number of pointers

Powered by Google App Engine
This is Rietveld 408576698