Invoke AttachmentUploader and update AttachmentIds.

components/sync_driver/generic_change_processor_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_FACTORY_H_
 #define COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_FACTORY_H_
 
 #include "base/memory/weak_ptr.h"
 
 namespace syncer {
 class AttachmentService;
 class SyncableService;
 class SyncMergeResult;
 struct UserShare;
 }
 
 namespace browser_sync {
 
 class DataTypeErrorHandler;
 class GenericChangeProcessor;
+class SyncApiComponentFactory;
 
 // Because GenericChangeProcessors are created and used only from the model
 // thread, their lifetime is strictly shorter than other components like
 // DataTypeController, which live before / after communication with model
 // threads begins and ends.
 // The GCP is created "on the fly" at just the right time, on just the right
 // thread. Given that, we use a factory to instantiate GenericChangeProcessors
 // so that tests can choose to use a fake processor (i.e instead of injection).
 class GenericChangeProcessorFactory {
  public:
   GenericChangeProcessorFactory();
   virtual ~GenericChangeProcessorFactory();
   virtual scoped_ptr<GenericChangeProcessor> CreateGenericChangeProcessor(
       syncer::UserShare* user_share,
       browser_sync::DataTypeErrorHandler* error_handler,
       const base::WeakPtr<syncer::SyncableService>& local_service,
       const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
-      scoped_ptr<syncer::AttachmentService> attachment_service);
+      SyncApiComponentFactory* sync_factory);

[maniscalco, 2014/05/15 20:09:28]

Can you document the sync_factory parameter?  I think it's worth calling out
that GCP won't own or manage the sync_factory and that it will only use it in
its ctor (that way, the caller doesn't have to guarantee the sync_factory
outlives the GCP).

[pavely, 2014/05/16 00:19:10]

Done.

+
  private:
   DISALLOW_COPY_AND_ASSIGN(GenericChangeProcessorFactory);
 };
 
 }  // namespace browser_sync
 
 #endif  // COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_FACTORY_H_