Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: sync/syncable/mutable_entry.h

Issue 272043002: Invoke AttachmentUploader and update AttachmentIds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_SYNCABLE_MUTABLE_ENTRY_H_ 5 #ifndef SYNC_SYNCABLE_MUTABLE_ENTRY_H_
6 #define SYNC_SYNCABLE_MUTABLE_ENTRY_H_ 6 #define SYNC_SYNCABLE_MUTABLE_ENTRY_H_
7 7
8 #include "sync/base/sync_export.h" 8 #include "sync/base/sync_export.h"
9 #include "sync/internal_api/public/base/model_type.h" 9 #include "sync/internal_api/public/base/model_type.h"
10 #include "sync/syncable/entry.h" 10 #include "sync/syncable/entry.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 void PutUniquePosition(const UniquePosition& value); 54 void PutUniquePosition(const UniquePosition& value);
55 55
56 // Sets the position of this item, and updates the entry kernels of the 56 // Sets the position of this item, and updates the entry kernels of the
57 // adjacent siblings so that list invariants are maintained. Returns false 57 // adjacent siblings so that list invariants are maintained. Returns false
58 // and fails if |predecessor_id| does not identify a sibling. Pass the root 58 // and fails if |predecessor_id| does not identify a sibling. Pass the root
59 // ID to put the node in first position. 59 // ID to put the node in first position.
60 bool PutPredecessor(const Id& predecessor_id); 60 bool PutPredecessor(const Id& predecessor_id);
61 61
62 void PutAttachmentMetadata( 62 void PutAttachmentMetadata(
63 const sync_pb::AttachmentMetadata& attachment_metadata); 63 const sync_pb::AttachmentMetadata& attachment_metadata);
64 // Update attachment metadata, replace all records matching attachment id's
maniscalco 2014/05/09 18:12:11 nit: there should be a blank line above this comme
pavely 2014/05/13 23:06:44 Done.
65 // unique id with updated attachment id.
66 void UpdateAttachmentId(const sync_pb::AttachmentIdProto& attachment_id);
maniscalco 2014/05/09 18:12:11 Consider renaming attachment_id to updated_attachm
pavely 2014/05/13 23:06:44 Done.
64 67
65 private: 68 private:
66 // Kind of redundant. We should reduce the number of pointers 69 // Kind of redundant. We should reduce the number of pointers
67 // floating around if at all possible. Could we store this in Directory? 70 // floating around if at all possible. Could we store this in Directory?
68 // Scope: Set on construction, never changed after that. 71 // Scope: Set on construction, never changed after that.
69 WriteTransaction* const write_transaction_; 72 WriteTransaction* const write_transaction_;
70 73
71 DISALLOW_COPY_AND_ASSIGN(MutableEntry); 74 DISALLOW_COPY_AND_ASSIGN(MutableEntry);
72 }; 75 };
73 76
74 // This function sets only the flags needed to get this entry to sync. 77 // This function sets only the flags needed to get this entry to sync.
75 bool MarkForSyncing(syncable::MutableEntry* e); 78 bool MarkForSyncing(syncable::MutableEntry* e);
76 79
77 } // namespace syncable 80 } // namespace syncable
78 } // namespace syncer 81 } // namespace syncer
79 82
80 #endif // SYNC_SYNCABLE_MUTABLE_ENTRY_H_ 83 #endif // SYNC_SYNCABLE_MUTABLE_ENTRY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698