Invoke AttachmentUploader and update AttachmentIds.

sync/internal_api/public/write_transaction.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_WRITE_TRANSACTION_H_
 #define SYNC_INTERNAL_API_PUBLIC_WRITE_TRANSACTION_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "sync/api/sync_change_processor.h"
@@ skipping 34 matching lines @@
   syncable::WriteTransaction* GetWrappedWriteTrans() { return transaction_; }
 
   // Set's a |type|'s local context. |refresh_status| controls whether
   // a datatype refresh is performed (clearing the progress marker token and
   // setting the version of all synced entities to 1).
   void SetDataTypeContext(
       ModelType type,
       syncer::SyncChangeProcessor::ContextRefreshStatus refresh_status,
       const std::string& context);
 
+  // Attachment id was just updated. Propagate this change to all entries that
+  // refer this attachment id.
+  void UpdateEntriesWithAttachmentId(const AttachmentId& attachment_id);

[maniscalco, 2014/05/09 18:12:11]

How about a unit test for this method?  directory_unittest.cc might be a good
place for it.

[pavely, 2014/05/13 23:06:44]

directory_unittest tests the other WriteTransaction. This one is not accessible
from there.
Method is straightforward so I decided not to test it.
On 2014/05/09 18:12:11, maniscalco wrote:

[maniscalco, 2014/05/15 20:09:28]

You are right, directory_unittest is for the other WriteTransaction.  I'm OK
with omitting a test for this method.

On 2014/05/13 23:06:44, pavely wrote:

+
  protected:
   WriteTransaction() {}
 
   void SetTransaction(syncable::WriteTransaction* trans) {
     transaction_ = trans;
   }
 
  private:
   void* operator new(size_t size);  // Transaction is meant for stack use only.
 
   // The underlying syncable object which this class wraps.
   syncable::WriteTransaction* transaction_;
 
   DISALLOW_COPY_AND_ASSIGN(WriteTransaction);
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_WRITE_TRANSACTION_H_