Invoke AttachmentUploader and update AttachmentIds.

sync/api/attachments/fake_attachment_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/api/attachments/fake_attachment_service.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "sync/api/attachments/attachment.h"
 #include "sync/api/attachments/fake_attachment_store.h"
@@ skipping 21 matching lines @@
   scoped_ptr<syncer::AttachmentStore> attachment_store(
       new syncer::FakeAttachmentStore(base::MessageLoopProxy::current()));
   scoped_ptr<AttachmentUploader> attachment_uploader(
       new FakeAttachmentUploader);
   scoped_ptr<syncer::AttachmentService> attachment_service(
       new syncer::FakeAttachmentService(attachment_store.Pass(),
                                         attachment_uploader.Pass()));
   return attachment_service.Pass();
 }
 
+void FakeAttachmentService::SetDelegate(Delegate* delegate) {
+  delegate_ = delegate;
+}
+
 void FakeAttachmentService::GetOrDownloadAttachments(
     const AttachmentIdList& attachment_ids,
     const GetOrDownloadCallback& callback) {
   DCHECK(CalledOnValidThread());
   attachment_store_->Read(attachment_ids,
                           base::Bind(&FakeAttachmentService::ReadDone,
                                      weak_ptr_factory_.GetWeakPtr(),
                                      callback));
 }
 
 void FakeAttachmentService::DropAttachments(
     const AttachmentIdList& attachment_ids,
     const DropCallback& callback) {
   DCHECK(CalledOnValidThread());
   attachment_store_->Drop(attachment_ids,
                           base::Bind(&FakeAttachmentService::DropDone,
                                      weak_ptr_factory_.GetWeakPtr(),
                                      callback));
 }
 
 void FakeAttachmentService::StoreAttachments(const AttachmentList& attachments,
                                              const StoreCallback& callback) {
   DCHECK(CalledOnValidThread());
   attachment_store_->Write(attachments,
                            base::Bind(&FakeAttachmentService::WriteDone,
                                       weak_ptr_factory_.GetWeakPtr(),
                                       callback));
-  // TODO(maniscalco): Ensure the linked attachments are schedule for upload to
-  // the server (bug 356351).
+  for (AttachmentList::const_iterator iter = attachments.begin();
+       iter != attachments.end();
+       ++iter) {
+    attachment_uploader_->UploadAttachment(
+        *iter,
+        base::Bind(&FakeAttachmentService::UploadDone,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }
 }
 
 void FakeAttachmentService::OnSyncDataDelete(const SyncData& sync_data) {
   DCHECK(CalledOnValidThread());
   // TODO(maniscalco): One or more of sync_data's attachments may no longer be
   // referenced anywhere. We should probably delete them at this point (bug
   // 356351).
 }
 
 void FakeAttachmentService::OnSyncDataUpdate(
@@ skipping 36 matching lines @@
   AttachmentService::StoreResult store_result =
       AttachmentService::STORE_UNSPECIFIED_ERROR;
   if (result == AttachmentStore::SUCCESS) {
     store_result = AttachmentService::STORE_SUCCESS;
   }
   // TODO(maniscalco): Deal with case where an error occurred (bug 361251).
   base::MessageLoop::current()->PostTask(FROM_HERE,
                                          base::Bind(callback, store_result));
 }
 
+void FakeAttachmentService::UploadDone(
+    const AttachmentUploader::UploadResult& result,
+    const AttachmentId& attachment_id) {
+  DCHECK(delegate_);

[maniscalco, 2014/05/09 18:12:11]

I thought having a delegate_ was optional, no?

[pavely, 2014/05/13 23:06:44]

No, having delegate is not optional, I would rather pass delegate through
AttachmentService constructor but the problem is that AttachmentService itself
is constructed before GenericChangeProcessor. So I decided to go with setter
method.

+  if (result != AttachmentUploader::UPLOAD_SUCCESS)

[maniscalco, 2014/05/09 18:12:11]

Please add a TODO for dealing with error results.

[pavely, 2014/05/13 23:06:44]

Done.

+    return;
+  delegate_->OnAttachmentUploaded(attachment_id);
+}
+
 }  // namespace syncer