Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm

Issue 2720423003: Get Suggestions image only if it is not empty (Closed)
Patch Set: Fix tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm
diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm b/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm
index 60eb0ea39f2ac0b91b0653ac0eaf76dc1a11d44c..b8c00032bd0757d670e09f605a7d379ca9a0be78 100644
--- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm
+++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm
@@ -75,24 +75,31 @@ TEST(ContentSuggestionsArticleItemTest, CellIsConfiguredWithImage) {
EXPECT_EQ(image, cell.imageView.image);
}
-// Tests that configureCell: does not call the delegate is |imageBeingFetched|
-// is YES even if there is no image.
+// Tests that configureCell: does not call the delegate if it fetched the image
+// once.
TEST(ContentSuggestionsArticleItemTest, DontFetchImageIsImageIsBeingFetched) {
// Setup.
NSString* title = @"testTitle";
NSString* subtitle = @"testSubtitle";
GURL url = GURL("http://chromium.org");
- id delegateMock =
- OCMStrictProtocolMock(@protocol(ContentSuggestionsArticleItemDelegate));
+ id niceDelegateMock =
+ OCMProtocolMock(@protocol(ContentSuggestionsArticleItemDelegate));
ContentSuggestionsArticleItem* item =
[[ContentSuggestionsArticleItem alloc] initWithType:0
title:title
subtitle:subtitle
- delegate:delegateMock
+ delegate:niceDelegateMock
url:url];
- item.imageBeingFetched = YES;
+
+ OCMExpect([niceDelegateMock loadImageForArticleItem:item]);
ContentSuggestionsArticleCell* cell = [[[item cellClass] alloc] init];
ASSERT_EQ(nil, item.image);
+ [item configureCell:cell];
+ ASSERT_OCMOCK_VERIFY(niceDelegateMock);
+
+ id strictDelegateMock =
+ OCMStrictProtocolMock(@protocol(ContentSuggestionsArticleItemDelegate));
+ item.delegate = strictDelegateMock;
// Action.
[item configureCell:cell];
@@ -101,7 +108,6 @@ TEST(ContentSuggestionsArticleItemTest, DontFetchImageIsImageIsBeingFetched) {
EXPECT_EQ(nil, cell.imageView.image);
EXPECT_EQ(title, cell.titleLabel.text);
EXPECT_EQ(subtitle, cell.subtitleLabel.text);
- EXPECT_OCMOCK_VERIFY(delegateMock);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698