Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 272033003: [refactor] Change ordering of wrapkey parameters (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[refactor] Change ordering of wrapkey parameters crypto.subtle.wrapKey() orders the key to be wrapped before the wrapping key. Use the same convention throughout webcrypto code to avoid confusion. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269478

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M content/child/webcrypto/platform_crypto.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/webcrypto/shared_crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 1 chunk +1 line, -3 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
eroman
Low priority pedantry. On the plus side, should be easy to review! https://codereview.chromium.org/272033003/diff/1/content/child/webcrypto/webcrypto_impl.cc File content/child/webcrypto/webcrypto_impl.cc ...
6 years, 7 months ago (2014-05-08 23:35:45 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-08 23:44:01 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-08 23:52:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/272033003/1
6 years, 7 months ago (2014-05-09 00:00:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 03:38:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 07:07:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14082)
6 years, 7 months ago (2014-05-09 07:07:45 UTC) #7
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-09 15:50:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/272033003/1
6 years, 7 months ago (2014-05-09 15:53:35 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:00:31 UTC) #10
Message was sent while issue was closed.
Change committed as 269478

Powered by Google App Engine
This is Rietveld 408576698