Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 272033002: cc: fix pre-painting trigger for GPU rasterization (Closed)

Created:
6 years, 7 months ago by ernstm
Modified:
6 years, 7 months ago
Reviewers:
alokp, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: fix pre-painting trigger for GPU rasterization CUTOFF_ALLOW_NICE_TO_HAVE was only triggered for --force-gpu-rasterization. This patch triggers it when the active or the pending tree uses GPU rasterization. In case of a transition between CPU and GPU rasterization it is preferrable to pre-paint less on the CPU rasterized tree (which may checkerboard) than it is to pre-paint more on the GPU rasterized tree (which may stall the browser compositor). This patch depends on https://codereview.chromium.org/270823003/ R=enne@chromium.org, alokp@chromium.org BUG=368884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269682

Patch Set 1 #

Patch Set 2 : Update unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ernstm
PTAL
6 years, 7 months ago (2014-05-08 23:15:16 UTC) #1
alokp
lgtm
6 years, 7 months ago (2014-05-08 23:22:47 UTC) #2
enne (OOO)
lgtm
6 years, 7 months ago (2014-05-09 20:10:28 UTC) #3
alokp
The CQ bit was checked by alokp@chromium.org
6 years, 7 months ago (2014-05-10 14:14:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/272033002/1
6 years, 7 months ago (2014-05-10 14:15:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 16:12:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 16:47:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/25368)
6 years, 7 months ago (2014-05-10 16:47:58 UTC) #8
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 7 months ago (2014-05-10 22:06:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/272033002/20001
6 years, 7 months ago (2014-05-10 22:07:05 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:41:04 UTC) #11
Message was sent while issue was closed.
Change committed as 269682

Powered by Google App Engine
This is Rietveld 408576698