Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 2720273003: [Media Router] Remove binary messaging implementation. (Closed)
Patch Set: Apply suggested patch Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/android/router/media_router_android.cc
diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc
index 91cae709091fe5e8e95c1660da7ee28fe03b6a24..0dc832c1efb18bb774389285a1915f9195bc60cd 100644
--- a/chrome/browser/media/android/router/media_router_android.cc
+++ b/chrome/browser/media/android/router/media_router_android.cc
@@ -184,15 +184,8 @@ void MediaRouterAndroid::SendRouteBinaryMessage(
const MediaRoute::Id& route_id,
std::unique_ptr<std::vector<uint8_t>> data,
const SendRouteMessageCallback& callback) {
- int callback_id = message_callbacks_.Add(
- base::MakeUnique<SendRouteMessageCallback>(callback));
- JNIEnv* env = base::android::AttachCurrentThread();
- ScopedJavaLocalRef<jstring> jroute_id =
- base::android::ConvertUTF8ToJavaString(env, route_id);
- ScopedJavaLocalRef<jbyteArray> jbyte_array =
- base::android::ToJavaByteArray(env, &((*data)[0]), data->size());
- Java_ChromeMediaRouter_sendBinaryMessage(env, java_media_router_, jroute_id,
- jbyte_array, callback_id);
+ // Binary messaging is not supported on Android.
+ callback.Run(false);
}
void MediaRouterAndroid::AddIssue(const IssueInfo& issue_info) {
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698