Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java

Issue 2720273003: [Media Router] Remove binary messaging implementation. (Closed)
Patch Set: Apply suggested patch Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
index e687e5ba06f91b161359b5fe1c52e4eed80ac72c..5a897d98f1208a467404912f88701855e4c2a903 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
@@ -10,6 +10,9 @@ import android.support.v7.media.MediaRouteSelector;
import android.support.v7.media.MediaRouter;
import android.support.v7.media.MediaRouter.RouteInfo;
+import org.json.JSONException;
+import org.json.JSONObject;
+
import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.media.router.ChromeMediaRouter;
@@ -17,8 +20,6 @@ import org.chromium.chrome.browser.media.router.DiscoveryDelegate;
import org.chromium.chrome.browser.media.router.MediaRoute;
import org.chromium.chrome.browser.media.router.MediaRouteManager;
import org.chromium.chrome.browser.media.router.MediaRouteProvider;
-import org.json.JSONException;
-import org.json.JSONObject;
import java.lang.ref.WeakReference;
import java.util.ArrayList;
@@ -376,15 +377,6 @@ public class CastMediaRouteProvider implements MediaRouteProvider, DiscoveryDele
mManager.onMessageSentResult(success, nativeCallbackId);
}
- @Override
- public void sendBinaryMessage(String routeId, byte[] data, int nativeCallbackId) {
- // TODO(crbug.com/524128): Cast API does not support sending binary message
- // to receiver application. Binary data may be converted to String and send as
- // an app_message within it's own message namespace, using the string version.
- // Sending failure in the result callback for now.
- mManager.onMessageSentResult(false, nativeCallbackId);
- }
-
private boolean handleClientConnectMessage(JSONObject jsonMessage) throws JSONException {
String clientId = jsonMessage.getString("clientId");
if (clientId == null) return false;

Powered by Google App Engine
This is Rietveld 408576698