Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/views/frame/browser_view.cc

Issue 272024: Allow ESC to cancel ALT+SHIFT+T in Toolbar (Closed)
Patch Set: Only allow one traversal at a time Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/views/toolbar_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/frame/browser_view.h" 5 #include "chrome/browser/views/frame/browser_view.h"
6 6
7 #if defined(OS_LINUX) 7 #if defined(OS_LINUX)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 919 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 toolbar_->go_button()->ChangeMode( 930 toolbar_->go_button()->ChangeMode(
931 is_loading ? GoButton::MODE_STOP : GoButton::MODE_GO, force); 931 is_loading ? GoButton::MODE_STOP : GoButton::MODE_GO, force);
932 } 932 }
933 933
934 void BrowserView::UpdateToolbar(TabContents* contents, 934 void BrowserView::UpdateToolbar(TabContents* contents,
935 bool should_restore_state) { 935 bool should_restore_state) {
936 toolbar_->Update(contents, should_restore_state); 936 toolbar_->Update(contents, should_restore_state);
937 } 937 }
938 938
939 void BrowserView::FocusToolbar() { 939 void BrowserView::FocusToolbar() {
940 // Do not restore the button that previously had accessibility focus, if 940 toolbar_->InitializeTraversal();
941 // focus is set by using the toolbar focus keyboard shortcut.
942 toolbar_->set_acc_focused_view(NULL);
943 // HACK: Do not use RequestFocus() here, as the toolbar is not marked as
944 // "focusable". Instead bypass the sanity check in RequestFocus() and just
945 // force it to focus, which will do the right thing.
946 GetRootView()->FocusView(toolbar_);
947 } 941 }
948 942
949 void BrowserView::DestroyBrowser() { 943 void BrowserView::DestroyBrowser() {
950 // Explicitly delete the BookmarkBarView now. That way we don't have to 944 // Explicitly delete the BookmarkBarView now. That way we don't have to
951 // worry about the BookmarkBarView potentially outliving the Browser & 945 // worry about the BookmarkBarView potentially outliving the Browser &
952 // Profile. 946 // Profile.
953 bookmark_bar_view_.reset(); 947 bookmark_bar_view_.reset();
954 browser_.reset(); 948 browser_.reset();
955 } 949 }
956 950
(...skipping 1290 matching lines...) Expand 10 before | Expand all | Expand 10 after
2247 2241
2248 // static 2242 // static
2249 FindBar* BrowserWindow::CreateFindBar(Browser* browser) { 2243 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
2250 return browser::CreateFindBar(static_cast<BrowserView*>(browser->window())); 2244 return browser::CreateFindBar(static_cast<BrowserView*>(browser->window()));
2251 } 2245 }
2252 2246
2253 // static 2247 // static
2254 void BrowserList::AllBrowsersClosed() { 2248 void BrowserList::AllBrowsersClosed() {
2255 views::Window::CloseAllSecondaryWindows(); 2249 views::Window::CloseAllSecondaryWindows();
2256 } 2250 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/views/toolbar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698