chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc - Issue 2720223004: Use PaymentRequestItemList for Shipping screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

Issue 2720223004: Use PaymentRequestItemList for Shipping screen (Closed)

Patch Set: tryna fix tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/payment_method_view_controller.cc ('k') | chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h » ('j') | chrome/browser/ui/views/payments/payment_request_views_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc b/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

index b8d3deaa1e24a386a87ddff66f8544f8d681c39f..d494c04044fdab83e4391570491a7dfecab163d2 100644

--- a/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

@@ -57,7 +57,7 @@ IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, OneCardSelected) {

EXPECT_EQ(card, *request->selected_credit_card());

views::View* checkmark_view = list_view->child_at(0)->GetViewByID(

- static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));

+ static_cast<int>(DialogViewID::CHECKMARK_VIEW));

EXPECT_TRUE(checkmark_view->visible());

}

@@ -104,11 +104,11 @@ IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest,

EXPECT_EQ(card1, *request->selected_credit_card());

views::View* checkmark_view = list_view->child_at(0)->GetViewByID(

- static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));

+ static_cast<int>(DialogViewID::CHECKMARK_VIEW));

EXPECT_TRUE(checkmark_view->visible());

views::View* checkmark_view2 = list_view->child_at(1)->GetViewByID(

- static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));

+ static_cast<int>(DialogViewID::CHECKMARK_VIEW));

EXPECT_FALSE(checkmark_view2->visible());

// Simulate selecting the second card.