Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_views_util.cc

Issue 2720223004: Use PaymentRequestItemList for Shipping screen (Closed)
Patch Set: Removing extraneous import Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/payments/payment_request_views_util.h" 5 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 values.push_back(name_value); 208 values.push_back(name_value);
209 if (!phone_value.empty()) 209 if (!phone_value.empty())
210 values.push_back(phone_value); 210 values.push_back(phone_value);
211 if (!email_value.empty()) 211 if (!email_value.empty())
212 values.push_back(email_value); 212 values.push_back(email_value);
213 213
214 return base::MakeUnique<views::StyledLabel>( 214 return base::MakeUnique<views::StyledLabel>(
215 base::JoinString(values, base::ASCIIToUTF16("\n")), nullptr); 215 base::JoinString(values, base::ASCIIToUTF16("\n")), nullptr);
216 } 216 }
217 217
218 // Creates a views::Border object that can paint the gray horizontal ruler used
anthonyvd 2017/03/01 20:15:34 This comment was on both this and the declaration
tmartino 2017/03/01 22:48:14 Yes. They were identical, I think it was an artifa
219 // as a separator between items in the Payment Request dialog.
220 std::unique_ptr<views::Border> CreatePaymentRequestRowBorder() { 218 std::unique_ptr<views::Border> CreatePaymentRequestRowBorder() {
221 return views::CreateBorderPainter( 219 return views::CreateBorderPainter(
222 base::MakeUnique<PaymentRequestRowBorderPainter>(), 220 base::MakeUnique<PaymentRequestRowBorderPainter>(),
223 gfx::Insets()); 221 gfx::Insets());
224 } 222 }
225 223
226 } // namespace payments 224 } // namespace payments
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698