Use PaymentRequestItemList for Shipping screen

chrome/browser/ui/views/payments/payment_request_views_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
 #include "chrome/browser/ui/views/payments/payment_request_sheet_controller.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/geometry/point_f.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/vector_icons/vector_icons.h"
 #include "ui/views/border.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/vector_icon_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/painter.h"
+#include "ui/views/vector_icons.h"
 #include "ui/views/view.h"
 
 namespace {
 
 // TODO(tmartino): Consider combining this with the Android equivalent in
 // PersonalDataManager.java
 base::string16 GetAddressFromProfile(const autofill::AutofillProfile& profile,
                                      const std::string& locale) {
   std::vector<autofill::ServerFieldType> fields;
   fields.push_back(autofill::COMPANY_NAME);
@@ skipping 164 matching lines @@
     values.push_back(name_value);
   if (!phone_value.empty())
     values.push_back(phone_value);
   if (!email_value.empty())
     values.push_back(email_value);
 
   return base::MakeUnique<views::StyledLabel>(
       base::JoinString(values, base::ASCIIToUTF16("\n")), nullptr);
 }
 
-// Creates a views::Border object that can paint the gray horizontal ruler used
-// as a separator between items in the Payment Request dialog.
 std::unique_ptr<views::Border> CreatePaymentRequestRowBorder() {
   return views::CreateBorderPainter(
       base::MakeUnique<PaymentRequestRowBorderPainter>(),
       gfx::Insets());
 }
 
+std::unique_ptr<views::ImageView> CreateCheckmark(bool selected) {

[anthonyvd, 2017/03/01 15:37:00]

While you're moving this around: can you move it to the base Item class right
away (since we'll do it when refactoring anyways)?

[tmartino, 2017/03/01 20:00:30]

Done

+  std::unique_ptr<views::ImageView> checkmark =
+      base::MakeUnique<views::ImageView>();
+  checkmark->set_id(static_cast<int>(DialogViewID::CHECKMARK_VIEW));
+  checkmark->set_can_process_events_within_subtree(false);
+  checkmark->SetImage(gfx::CreateVectorIcon(views::kMenuCheckIcon, 0xFF609265));

[anthonyvd, 2017/03/01 15:37:00]

Can we move the 0xFF609265 color to a constant? (My bad on that one!)

[tmartino, 2017/03/01 20:00:30]

Done

+  checkmark->SetVisible(selected);
+  return checkmark;
+}
+
 }  // namespace payments