Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: ui/views/animation/ink_drop_host_view.h

Issue 2720183002: [Views] Update ink drop for omnibox icons (Closed)
Patch Set: Fixed tests and added comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/ink_drop_host_view.h
diff --git a/ui/views/animation/ink_drop_host_view.h b/ui/views/animation/ink_drop_host_view.h
index 151992097c1171866a94e8170f5bcd5686c53b27..c5679c6e002f7ac2ad72076e48fde77a18cf19c4 100644
--- a/ui/views/animation/ink_drop_host_view.h
+++ b/ui/views/animation/ink_drop_host_view.h
@@ -107,6 +107,8 @@ class VIEWS_EXPORT InkDropHostView : public View, public InkDropHost {
// Subclasses can override to return a mask for the ink drop. By default,
// returns nullptr (i.e no mask).
+ // TODO(bruthig): InkDropMasks do not currently work on Windows. See
bruthig 2017/05/01 22:42:18 Thx for adding this!
spqchan 2017/05/02 22:50:05 No prob~
+ // crbug.com/713359.
virtual std::unique_ptr<views::InkDropMask> CreateInkDropMask() const;
// Provides access to |ink_drop_|. Implements lazy initialization of

Powered by Google App Engine
This is Rietveld 408576698