[Views] Update ink drop for omnibox icons

ui/views/animation/ink_drop_impl.h

Index: ui/views/animation/ink_drop_impl.h
diff --git a/ui/views/animation/ink_drop_impl.h b/ui/views/animation/ink_drop_impl.h
index 961f80b0cfbd37373bf8bced5f2e82e2b95ade4e..96d131f773d75b17fd4746edd7c68767fed4c566 100644
--- a/ui/views/animation/ink_drop_impl.h
+++ b/ui/views/animation/ink_drop_impl.h
@@ -72,6 +72,7 @@ class VIEWS_EXPORT InkDropImpl : public InkDrop,
   void SnapToActivated() override;
   void SetHovered(bool is_hovered) override;
   void SetFocused(bool is_focused) override;
+  bool ShouldHighlight() const override;

[bruthig, 2017/03/08 18:58:24]

If we decide to keep ShouldHighlight() as a virtual function in InkDrop then it
should be marked as final here.  Child classes should not be able to control the
visibility of the highlight by overriding this function.  The InkDropImpl has
some dependencies on when the return value of ShouldHighlight() changes.  For
example see InkDropImpl::SetShowHighlightOnHover().

Let me rephrase this, I think there is more effort required to make the
InkDropImpl work well if this function as overridable and I don't think it is
worth it.

[spqchan, 2017/03/14 00:07:52]

Used IsHighlightFadingInOrVisible() instead. Let me know if there are any
concerns!

 
  private:
   friend class InkDropImplTest;
@@ -245,10 +246,6 @@ class VIEWS_EXPORT InkDropImpl : public InkDrop,
                     base::TimeDelta animation_duration,
                     bool explode);
 
-  // Returns true if |this| the highlight should be visible based on the
-  // hover/focus status.
-  bool ShouldHighlight() const;
-
   // Returns true if |this| the hilight should be visible based on the focus
   // status.
   bool ShouldHighlightBasedOnFocus() const;