Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2720183002: [Views] Update ink drop for omnibox icons (Closed)
Patch Set: Update the behavior Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
index cd38b72fbfd798f5e6f0099d91368f05ba3f17fd..19765cc2844697b894cf2cc79a4b392bc683b4cd 100644
--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
@@ -59,6 +59,7 @@
#include "ui/views/layout/layout_manager.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_observer.h"
#include "url/gurl.h"
namespace {
@@ -354,6 +355,7 @@ WebsiteSettingsPopupView::~WebsiteSettingsPopupView() {
// static
void WebsiteSettingsPopupView::ShowPopup(
views::View* anchor_view,
+ views::WidgetObserver* widget_observer,
const gfx::Rect& anchor_rect,
Profile* profile,
content::WebContents* web_contents,
@@ -377,6 +379,10 @@ void WebsiteSettingsPopupView::ShowPopup(
anchor_view, parent_window, profile, web_contents, url, security_info);
if (!anchor_view)
popup->SetAnchorRect(anchor_rect);
+
+ if (widget_observer)
+ popup->GetWidget()->AddObserver(widget_observer);
+
popup->GetWidget()->Show();
}

Powered by Google App Engine
This is Rietveld 408576698