[Views] Update ink drop for omnibox icons

ash/shelf/shelf_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_view.h"
 
 #include <algorithm>
 #include <memory>
 #include <utility>
 #include <vector>
@@ skipping 1868 matching lines @@
     ink_drop_->AnimateToState(ink_drop_state);
   }
   void SnapToActivated() override { ink_drop_->SnapToActivated(); }
   void SetHovered(bool is_hovered) override {
     ink_drop_->SetHovered(is_hovered);
   }
   void SetFocused(bool is_focused) override {
     ink_drop_->SetFocused(is_focused);
   }
 
+  bool IsHighlightFadingInOrVisible() const override {
+    return ink_drop_->IsHighlightFadingInOrVisible();
+  }
+
+  // TODO(spqchan): Setting this for ink_drop_ causes the ink drop tests to

[bruthig, 2017/05/01 22:42:18]

Which tests fail?  I tried running ash_unittests, on Linux, with the change to
call ink_drop_->SetShowHighlightOnHover(show_highlight_on_hover) here.

[spqchan, 2017/05/02 22:50:05]

Oh hey, looks like this fixed it:
https://chromium.googlesource.com/chromium/src/+/8c6e6113a0f57941108e5267f699...
The changes that they made in the CL were the tests that was failing.

Awesome, one less TODO for me. Thanks for checking it out!

+  // fail. This requires more investigation.
+  void SetShowHighlightOnHover(bool show_highlight_on_hover) override {}
+
+  void SetShowHighlightOnFocus(bool show_highlight_on_focus) override {
+    ink_drop_->SetShowHighlightOnFocus(show_highlight_on_focus);
+  }
+
   std::unique_ptr<views::InkDrop> ink_drop_;
   std::vector<views::InkDropState> requested_states_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(InkDropSpy);
 };
 
 // A ShelfItemDelegate that returns a menu for the shelf item.
 class ListMenuShelfItemDelegate : public ShelfItemDelegate {
  public:
@@ skipping 1116 matching lines @@
   EXPECT_EQ(views::InkDropState::ACTIVATED,
             overflow_button_ink_drop_->GetTargetInkDropState());
   EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
               IsEmpty());
 
   ASSERT_TRUE(test_api_->IsShowingOverflowBubble());
 }
 
 }  // namespace test
 }  // namespace ash