Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: ui/views/animation/ink_drop_observer.h

Issue 2720183002: [Views] Update ink drop for omnibox icons (Closed)
Patch Set: Rebased and fixed tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_VIEWS_ANIMATION_INK_DROP_OBSERVER_H_
6 #define UI_VIEWS_ANIMATION_INK_DROP_OBSERVER_H_
7
8 #include <string>
9
10 #include "base/macros.h"
11 #include "ui/views/animation/ink_drop_animation_ended_reason.h"
bruthig 2017/03/22 17:20:17 nit: Is this needed?
spqchan 2017/03/24 17:58:04 Done.
12 #include "ui/views/animation/ink_drop_state.h"
bruthig 2017/03/22 17:20:17 nit: Is this needed?
spqchan 2017/03/24 17:58:04 Done.
13 #include "ui/views/views_export.h"
14
15 namespace views {
16
17 // Observer to attach to an InkDropRipple.
bruthig 2017/03/22 17:20:17 'InkDropRipple' -> just 'InkDrop'
spqchan 2017/03/24 17:58:03 Done.
18 class VIEWS_EXPORT InkDropObserver {
19 public:
20 // Called when the animation of the current InkDrop has started.
bruthig 2017/03/22 17:20:16 Can you be explicit here and mention that this inc
spqchan 2017/03/24 17:58:04 Done.
21 virtual void InkDropAnimationStarted() = 0;
22
23 protected:
24 InkDropObserver() = default;
25 virtual ~InkDropObserver() = default;
26
27 private:
28 DISALLOW_COPY_AND_ASSIGN(InkDropObserver);
29 };
30
31 } // namespace views
32
33 #endif // UI_VIEWS_ANIMATION_INK_DROP_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698