Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/browser_resources.grd

Issue 272013002: Provide skeleton for ChromeVox next. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/resources/chromeos/chromevox_next/background/background.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_resources.grd
diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd
index 53f8a2cfd0e9def86ef1bc6e5141e359097c3cbc..db071e80b522ebd0a28099b6e654a10c20b0a0e6 100644
--- a/chrome/browser/browser_resources.grd
+++ b/chrome/browser/browser_resources.grd
@@ -295,8 +295,14 @@
<include name="IDR_CRYPTOHOME_HTML" file="resources\chromeos\cryptohome.html" flattenhtml="true" type="BINDATA" />
<include name="IDR_CRYPTOHOME_JS" file="resources\chromeos\cryptohome.js" type="BINDATA" />
<!-- manifest file of ChromeVox accessibility extension -->
- <include name="IDR_CHROMEVOX_MANIFEST" file="resources\chromeos\chromevox\manifest.json" type="BINDATA" />
- <include name="IDR_CHROMEVOX_GUEST_MANIFEST" file="resources\chromeos\chromevox\manifest_guest.json" type="BINDATA" />
+ <if expr="'use_chromevox_next' in defs">
+ <include name="IDR_CHROMEVOX_MANIFEST" file="resources\chromeos\chromevox_next\manifest.json" type="BINDATA" />
+ <include name="IDR_CHROMEVOX_GUEST_MANIFEST" file="resources\chromeos\chromevox\manifest_guest.json" type="BINDATA" />
dmazzoni 2014/05/08 23:29:27 Don't you want to use a chromevox next guest manif
David Tseng 2014/05/08 23:37:47 What caused us to need to use a guest manifest? I'
+ </if>
+ <if expr="not 'use_chromevox_next' in defs">
dmazzoni 2014/05/08 23:29:27 This essentially makes ChromeVox Next a compile-ti
David Tseng 2014/05/08 23:37:47 I'm mixed on this. I did it this way for the initi
+ <include name="IDR_CHROMEVOX_MANIFEST" file="resources\chromeos\chromevox\manifest.json" type="BINDATA" />
+ <include name="IDR_CHROMEVOX_GUEST_MANIFEST" file="resources\chromeos\chromevox\manifest_guest.json" type="BINDATA" />
+ </if>
<!-- manifest file of Connectivity Diagnostics app -->
<include name="IDR_CONNECTIVITY_DIAGNOSTICS_MANIFEST" file="resources\chromeos\connectivity_diagnostics\manifest.json" type="BINDATA" />
<include name="IDR_CONNECTIVITY_DIAGNOSTICS_LAUNCHER_MANIFEST" file="resources\chromeos\connectivity_diagnostics_launcher\manifest.json" type="BINDATA" />
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/resources/chromeos/chromevox_next/background/background.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698