VM: Make Dart::FeaturesString respect isolate flags controlling asserts and type checks.

VM: Make Dart::FeaturesString respect isolate flags controlling asserts and type checks.

Before it simply looked at FLAG_enable_{asserts/type_checks}.

We allow disabling or enabling type checks / asserts for newly created isolates
through Dart_IsolateFlags even when they are enabled globally through
FLAG_enable_{asserts/type_checks} flags.

This change allows isolates to use app-jit snapshots trained with type checks /
asserts disabled as long as isolate itself has type check and asserts disabled,
independent of whether FLAG_enable_{asserts/type_checks} is set globally or not.

Additionally disable type checks and asserts on Kernel isolate even if flags
FLAG_enable_{asserts/type_checks} are set.

This change allows to train Kernel app-jit snapshot once and use it both for

$ dart --dfe=...

and for

$ dart --checked --dfe=...

configurations.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/ff9c17504a209d5f8a2b975fb45083c1fa75b8d5

[Vyacheslav Egorov (Google), 2017-02-28 14:02:40]

vegorov@google.com changed reviewers:
+ rmacnak@google.com

[Vyacheslav Egorov (Google), 2017-02-28 14:02:40]

Hi Ryan,

Please take a look.

[rmacnak, 2017-02-28 17:30:49]

LGTM

(Noting this is very similar to the stalled CL
https://codereview.chromium.org/2669543003/)

[Vyacheslav Egorov (Google), 2017-02-28 20:05:32]

Description was changed from

==========
VM: Make Dart::FeaturesString respect isolate flags controlling asserts and type
checks.

Before it simply looked at FLAG_enable_{asserts/type_checks}.

We allow disabling or enabling type checks / asserts for newly created isolates
through Dart_IsolateFlags even when they are enabled globally through
FLAG_enable_{asserts/type_checks} flags.

This change allows isolates to use app-jit snapshots trained with type checks /
asserts disabled as long as isolate itself has type check and asserts disabled,
independent of whether FLAG_enable_{asserts/type_checks} is set globally or not.

Additionally disable type checks and asserts on Kernel isolate even if flags
FLAG_enable_{asserts/type_checks} are set.

This change allows to train Kernel app-jit snapshot once and use it both for

$ dart --dfe=...

and for

$ dart --checked --dfe=...

configurations.

BUG=
==========

to

==========
VM: Make Dart::FeaturesString respect isolate flags controlling asserts and type
checks.

Before it simply looked at FLAG_enable_{asserts/type_checks}.

We allow disabling or enabling type checks / asserts for newly created isolates
through Dart_IsolateFlags even when they are enabled globally through
FLAG_enable_{asserts/type_checks} flags.

This change allows isolates to use app-jit snapshots trained with type checks /
asserts disabled as long as isolate itself has type check and asserts disabled,
independent of whether FLAG_enable_{asserts/type_checks} is set globally or not.

Additionally disable type checks and asserts on Kernel isolate even if flags
FLAG_enable_{asserts/type_checks} are set.

This change allows to train Kernel app-jit snapshot once and use it both for

$ dart --dfe=...

and for

$ dart --checked --dfe=...

configurations.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ff9c17504a209d5f8a2b975fb45083c1fa75b8d5
==========

[Vyacheslav Egorov (Google), 2017-02-28 20:05:33]

Committed patchset #1 (id:1) manually as
ff9c17504a209d5f8a2b975fb45083c1fa75b8d5 (presubmit successful).

[Vyacheslav Egorov (Google), 2017-02-28 20:16:05]

Ooops. We should have landed that.