chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc - Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2720083002: Make OnDataTimedout and OnDidPerformInstallableCheck mutually exclusive. (Closed)

Patch Set: Combine conditionals & rewrite TODO Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

index 2dea7aa3a00b0457d742b1b3fc685e6c50b030e1..1caf2b0b9e43c0d3615032295200e64cb6930fe4 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

@@ -209,7 +209,7 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(

const InstallableData& data) {

badge_icon_.reset();

- if (!web_contents() || !weak_observer_)

+ if (!web_contents() || !weak_observer_ || !is_installable_check_complete_)

dominickn 2017/02/28 23:23:15 Should this be is_installable_check_complete_ (not

F 2017/03/01 15:35:21 Done. Sorry

return;

is_installable_check_complete_ = true;

« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc » ('j') | no next file with comments »