third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl - Issue 2720003003: Implement DeviceOrientationEvent constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

Issue 2720003003: Implement DeviceOrientationEvent constructor. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl » ('j') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEventInit.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

index e409fec25938693374201ca2e1cabd88e7705044..c675469ab85e3fefe18045c145f4ff9880811cbc 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

@@ -25,7 +25,7 @@

// https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientation

-// TODO(foolip): DeviceOrientationEvent should have a constructor.

+[Constructor(DOMString type, optional DeviceOrientationEventInit eventInitDict)]

interface DeviceOrientationEvent : Event {

readonly attribute double? alpha;

readonly attribute double? beta;