Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: src/ia32/assembler-ia32-inl.h

Issue 2719953002: Add Int32x4 Wasm Simd Binops, compare ops, select (Closed)
Patch Set: Rebase again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/assembler-ia32-inl.h
diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h
index 5225229f202fc734ebe57207a1100747bcdbc10a..d8a107b113d1a1ab057e472e8ce6bb739fe5f87c 100644
--- a/src/ia32/assembler-ia32-inl.h
+++ b/src/ia32/assembler-ia32-inl.h
@@ -48,7 +48,7 @@ namespace internal {
bool CpuFeatures::SupportsCrankshaft() { return true; }
-bool CpuFeatures::SupportsSimd128() { return true; }
+bool CpuFeatures::SupportsWasmSimd128() { return IsSupported(SSE4_1); }
bbudge 2017/03/14 22:19:29 I think this could be weaker with the current code
gdeepti 2017/03/14 22:26:09 Defer to Jing here, but added this with the assump
Jing 2017/03/15 08:20:33 I think the strict check for SSE4_1 is needed, bec
gdeepti 2017/03/15 13:23:03 Thanks for confirming, will leave this as a check
static const byte kCallOpcode = 0xE8;
static const int kNoCodeAgeSequenceLength = 5;

Powered by Google App Engine
This is Rietveld 408576698