Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: media/test/pipeline_integration_test.cc

Issue 2719883005: Revert of Replace FFmpegDemuxer thread per element with base::TaskScheduler. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/test/BUILD.gn ('k') | media/test/pipeline_integration_test_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 // but the numerator will be truncated in the TOC as 250, losing precision. 1716 // but the numerator will be truncated in the TOC as 250, losing precision.
1717 base::TimeDelta seek_time(0.98 * pipeline_->GetMediaDuration()); 1717 base::TimeDelta seek_time(0.98 * pipeline_->GetMediaDuration());
1718 1718
1719 ASSERT_TRUE(Seek(seek_time)); 1719 ASSERT_TRUE(Seek(seek_time));
1720 Play(); 1720 Play();
1721 ASSERT_TRUE(WaitUntilOnEnded()); 1721 ASSERT_TRUE(WaitUntilOnEnded());
1722 1722
1723 EXPECT_HASH_EQ(config.hash, GetAudioHash()); 1723 EXPECT_HASH_EQ(config.hash, GetAudioHash());
1724 } 1724 }
1725 1725
1726 // TODO(CHCUNNINGHAM): Re-enable for OSX once 1% flakiness is root caused.
1727 // See http://crbug.com/571898
1728 #if !defined(OS_MACOSX)
1726 // CBR seeks should always be fast and accurate. 1729 // CBR seeks should always be fast and accurate.
1727 INSTANTIATE_TEST_CASE_P( 1730 INSTANTIATE_TEST_CASE_P(
1728 CBRSeek_HasTOC, 1731 CBRSeek_HasTOC,
1729 Mp3FastSeekIntegrationTest, 1732 Mp3FastSeekIntegrationTest,
1730 ::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-has-TOC.mp3", 1733 ::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-has-TOC.mp3",
1731 "-0.71,0.36,2.96,2.68,2.11,-1.08,"))); 1734 "-0.71,0.36,2.96,2.68,2.10,-1.08,")));
1735 #endif
1732 1736
1733 INSTANTIATE_TEST_CASE_P( 1737 INSTANTIATE_TEST_CASE_P(
1734 CBRSeeks_NoTOC, 1738 CBRSeeks_NoTOC,
1735 Mp3FastSeekIntegrationTest, 1739 Mp3FastSeekIntegrationTest,
1736 ::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-no-TOC.mp3", 1740 ::testing::Values(Mp3FastSeekParams("bear-audio-10s-CBR-no-TOC.mp3",
1737 "0.95,0.56,1.34,0.47,1.77,0.84,"))); 1741 "0.95,0.56,1.34,0.47,1.77,0.84,")));
1738 1742
1739 // VBR seeks can be fast *OR* accurate, but not both. We chose fast. 1743 // VBR seeks can be fast *OR* accurate, but not both. We chose fast.
1740 INSTANTIATE_TEST_CASE_P( 1744 INSTANTIATE_TEST_CASE_P(
1741 VBRSeeks_HasTOC, 1745 VBRSeeks_HasTOC,
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
2571 2575
2572 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) { 2576 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) {
2573 ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm")); 2577 ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm"));
2574 Play(); 2578 Play();
2575 ASSERT_TRUE(WaitUntilOnEnded()); 2579 ASSERT_TRUE(WaitUntilOnEnded());
2576 ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000), 2580 ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000),
2577 demuxer_->GetStartTime()); 2581 demuxer_->GetStartTime());
2578 } 2582 }
2579 2583
2580 } // namespace media 2584 } // namespace media
OLDNEW
« no previous file with comments | « media/test/BUILD.gn ('k') | media/test/pipeline_integration_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698