Create Fasta bootstrap test.

Create Fasta bootstrap test.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/86cad489934a6baca6f475e828b7888c4049b37d

[ahe, 2017-02-27 14:27:00]

ahe@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2017-02-28 11:47:37]

LGTM

https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
File pkg/front_end/test/fasta/bootstrap_test.dart (right):

https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
pkg/front_end/test/fasta/bootstrap_test.dart:32: Uri compiledOnceCompiler =
tmp.uri.resolve("fasta1.dill");
Why are these names ending in compiler?

[ahe, 2017-02-28 11:52:35]

Thank you, Karl!

https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
File pkg/front_end/test/fasta/bootstrap_test.dart (right):

https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
pkg/front_end/test/fasta/bootstrap_test.dart:32: Uri compiledOnceCompiler =
tmp.uri.resolve("fasta1.dill");
On 2017/02/28 11:47:37, karlklose wrote:
> Why are these names ending in compiler?

Because it means "compiler that was compiled once".

And because it felt consistent with "sourceCompiler".

Do you think it would be better if I remove the compiler suffix?

[karlklose, 2017-02-28 11:54:28]

On 2017/02/28 11:52:35, ahe wrote:
> Thank you, Karl!
> 
>
https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
> File pkg/front_end/test/fasta/bootstrap_test.dart (right):
> 
>
https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
> pkg/front_end/test/fasta/bootstrap_test.dart:32: Uri compiledOnceCompiler =
> tmp.uri.resolve("fasta1.dill");
> On 2017/02/28 11:47:37, karlklose wrote:
> > Why are these names ending in compiler?
> 
> Because it means "compiler that was compiled once".
> 
> And because it felt consistent with "sourceCompiler".
> 
> Do you think it would be better if I remove the compiler suffix?

I would replace it with 'Output'.

[ahe, 2017-02-28 14:44:25]

On 2017/02/28 11:54:28, karlklose wrote:
> On 2017/02/28 11:52:35, ahe wrote:
> > Thank you, Karl!
> > 
> >
>
https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
> > File pkg/front_end/test/fasta/bootstrap_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/2719863003/diff/1/pkg/front_end/test/fasta/bo...
> > pkg/front_end/test/fasta/bootstrap_test.dart:32: Uri compiledOnceCompiler =
> > tmp.uri.resolve("fasta1.dill");
> > On 2017/02/28 11:47:37, karlklose wrote:
> > > Why are these names ending in compiler?
> > 
> > Because it means "compiler that was compiled once".
> > 
> > And because it felt consistent with "sourceCompiler".
> > 
> > Do you think it would be better if I remove the compiler suffix?
> 
> I would replace it with 'Output'.

Done.

Thanks!

[ahe, 2017-02-28 14:49:11]

Description was changed from

==========
Create Fasta bootstrap test.
==========

to

==========
Create Fasta bootstrap test.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86cad489934a6baca6f475e828b7888c4049b37d
==========

[ahe, 2017-02-28 14:49:12]

Committed patchset #2 (id:20001) manually as
86cad489934a6baca6f475e828b7888c4049b37d (presubmit successful).