Issue 2719853004: Deprecate the analysis.updateOptions request

Issue 2719853004: Deprecate the analysis.updateOptions request (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson

Modified:
3 years, 9 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	pkg/analysis_server/doc/api.html	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/AnalysisOptions.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Brian Wilkerson

A little more API clean-up. I'm fairly sure none of our clients are using this, ...

3 years, 9 months ago (2017-02-27 15:53:41 UTC) #2

devoncarew

lgtm Should we also change the implementation to a no-op? I ask because I think ...

3 years, 9 months ago (2017-02-27 16:50:58 UTC) #3

Brian Wilkerson

Committed patchset #1 (id:1) manually as c416aabed17d92a39d80c879ee2145f5c4f97999 (presubmit successful).

3 years, 9 months ago (2017-02-27 18:37:07 UTC) #5

Brian Wilkerson

3 years, 9 months ago (2017-02-27 18:37:46 UTC) #6

Message was sent while issue was closed.

> Should we also change the implementation to a no-op?

Or just update the test to say "anything is fine"? I'm not sure what the best
approach is.