Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 271983002: Remove git-cr{up,sync} and replace with informative shell script. (Closed)

Created:
6 years, 7 months ago by iannucci
Modified:
6 years, 7 months ago
Reviewers:
Michael Moss, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Remove git-cr{up,sync} and replace with informative shell script. R=mmoss@chromium.org, szager@chromium.org BUG=371421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269088

Patch Set 1 #

Patch Set 2 : quotes #

Total comments: 3

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -287 lines) Patch
D crup-runner.sh View 1 chunk +0 lines, -128 lines 0 comments Download
M git-crsync View 1 chunk +1 line, -1 line 0 comments Download
M git-crup View 1 2 1 chunk +32 lines, -158 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
iannucci
6 years, 7 months ago (2014-05-08 21:24:38 UTC) #1
iannucci
SAMPLE OUTPUT: Sorry iannucci, but the git-submodule flow has been deprecated in order to simplify ...
6 years, 7 months ago (2014-05-08 21:25:28 UTC) #2
szager1
Please include this link in the spew: https://code.google.com/p/chromium/wiki/UsingGitSubmodules#switch_to_gclient
6 years, 7 months ago (2014-05-08 21:45:31 UTC) #3
szager1
https://codereview.chromium.org/271983002/diff/20001/git-crup File git-crup (right): https://codereview.chromium.org/271983002/diff/20001/git-crup#newcode28 git-crup:28: cat <<EOF This would read better if you here-filed ...
6 years, 7 months ago (2014-05-08 21:46:39 UTC) #4
iannucci
PTAL https://codereview.chromium.org/271983002/diff/20001/git-crup File git-crup (right): https://codereview.chromium.org/271983002/diff/20001/git-crup#newcode13 git-crup:13: echo Please consult https://code.google.com/p/chromium/wiki/UsingGitSubmodules Link is up here. ...
6 years, 7 months ago (2014-05-08 21:52:30 UTC) #5
szager1
lgtm
6 years, 7 months ago (2014-05-08 21:54:59 UTC) #6
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-08 21:56:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/271983002/40001
6 years, 7 months ago (2014-05-08 21:57:54 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 21:59:49 UTC) #9
Message was sent while issue was closed.
Change committed as 269088

Powered by Google App Engine
This is Rietveld 408576698