Convert first contentful paint logging to the new UKM client API

chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 437d5c9a6df56d6bf610f1e75ce3f6b2dfd0e894..9843b73042c58f2f05e4a595905ad9b96edcc620 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -8,6 +8,14 @@
 #include "base/macros.h"
 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
 
+namespace internal {
+
+// Name constants are exposed here so they can be referenced from tests.
+extern const char kUkmPageLoadEventName[];
+extern const char kUkmFirstContentfulPaintName[];
+
+}  // namespace internal
+
 // If URL-Keyed-Metrics (UKM) is enabled in the system, this is used to
 // populate it with top-level page-load metrics.
 class UkmPageLoadMetricsObserver
@@ -18,6 +26,7 @@ class UkmPageLoadMetricsObserver
   CreateIfNeeded();
 
   UkmPageLoadMetricsObserver();
+  ~UkmPageLoadMetricsObserver() override;
 
   // page_load_metrics::PageLoadMetricsObserver implementation:
   ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
@@ -32,12 +41,20 @@ class UkmPageLoadMetricsObserver
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& info) override;
 
+  void OnFailedProvisionalLoad(
+      const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+      const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
   void OnComplete(const page_load_metrics::PageLoadTiming& timing,
                   const page_load_metrics::PageLoadExtraInfo& info) override;
 
  private:
-  void SendMetricsToUkm(const page_load_metrics::PageLoadTiming& timing,
-                        const page_load_metrics::PageLoadExtraInfo& info);
+  void AddTimingMetrics(const page_load_metrics::PageLoadTiming& timing);

[rkaplow, 2017/03/01 23:54:39]

wouldn't mind comments on these too

[Bryan McQuade, 2017/03/02 03:49:50]

done

+  void AddPageLoadExtraInfoMetrics(
+      const page_load_metrics::PageLoadExtraInfo& info,
+      base::TimeTicks app_background_time);
+
+  const int32_t source_id_;

[rkaplow, 2017/03/01 23:54:39]

comment on how this is used

[Bryan McQuade, 2017/03/02 03:49:50]

done

 
   DISALLOW_COPY_AND_ASSIGN(UkmPageLoadMetricsObserver);
 };