Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/ukm/ukm_source.cc

Issue 2719823003: Convert first contentful paint logging to the new UKM client API (Closed)
Patch Set: limit to fcp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ukm/ukm_source.cc
diff --git a/components/ukm/ukm_source.cc b/components/ukm/ukm_source.cc
index cc52f5baa9a4d375114f0c71427e17b24f3ffeb1..758ff8cd57e189f5950da2939cf3289473ca7a4f 100644
--- a/components/ukm/ukm_source.cc
+++ b/components/ukm/ukm_source.cc
@@ -13,14 +13,12 @@ UkmSource::UkmSource() = default;
UkmSource::~UkmSource() = default;
-void UkmSource::PopulateProto(Source* proto_source) {
+void UkmSource::PopulateProto(Source* proto_source) const {
DCHECK(!proto_source->has_id());
DCHECK(!proto_source->has_url());
proto_source->set_id(GetHashedSourceID(id_));
- proto_source->set_url(committed_url_.spec());
- proto_source->set_first_contentful_paint_msec(
- first_contentful_paint_.InMilliseconds());
+ proto_source->set_url(url_.spec());
}
int32_t UkmSource::GetHashedSourceID(const content::GlobalRequestID& id) {

Powered by Google App Engine
This is Rietveld 408576698