Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: chrome/browser/lifetime/keep_alive_registry.h

Issue 2719813005: CrOS: Add print statements to help debug BrowserProcessImpl::Unpin crash. (Closed)
Patch Set: Added dumps. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/lifetime/keep_alive_registry.h
diff --git a/chrome/browser/lifetime/keep_alive_registry.h b/chrome/browser/lifetime/keep_alive_registry.h
index d8a7e4f0f95ac4df327ed72b896e86b45d346c3e..db3c61b1b6ead005bb4b5fecdef859383d40f24d 100644
--- a/chrome/browser/lifetime/keep_alive_registry.h
+++ b/chrome/browser/lifetime/keep_alive_registry.h
@@ -40,6 +40,11 @@ class KeepAliveRegistry {
// provided |origins| were not registered.
bool WouldRestartWithout(const std::vector<KeepAliveOrigin>& origins) const;
+ // TODO(sammiequon): This is used to help debug the crash in crbug.com/660962.
+ // Remove this when the crash is fixed or if verified to not be related to
+ // this.
+ std::string ToString() const;
sky 2017/03/22 03:56:16 How about naming this more specifically, possibly
+
private:
friend struct base::DefaultSingletonTraits<KeepAliveRegistry>;
// Friend to be able to use Register/Unregister

Powered by Google App Engine
This is Rietveld 408576698