Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/browser_process_impl.cc

Issue 2719813005: CrOS: Add print statements to help debug BrowserProcessImpl::Unpin crash. (Closed)
Patch Set: Whitespace. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_process_impl.h" 5 #include "chrome/browser/browser_process_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 1307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1318 if (IsShuttingDown()) { 1318 if (IsShuttingDown()) {
1319 // TODO(crbug.com/113031, crbug.com/625646): Temporary instrumentation. 1319 // TODO(crbug.com/113031, crbug.com/625646): Temporary instrumentation.
1320 base::debug::SetCrashKeyToStackTrace(crash_keys::kBrowserUnpinTrace, 1320 base::debug::SetCrashKeyToStackTrace(crash_keys::kBrowserUnpinTrace,
1321 release_last_reference_callstack_); 1321 release_last_reference_callstack_);
1322 CHECK(false); 1322 CHECK(false);
1323 } 1323 }
1324 } 1324 }
1325 1325
1326 void BrowserProcessImpl::Unpin() { 1326 void BrowserProcessImpl::Unpin() {
1327 DCHECK(CalledOnValidThread()); 1327 DCHECK(CalledOnValidThread());
1328 LOG(ERROR) << "Unpin";
1329
1328 release_last_reference_callstack_ = base::debug::StackTrace(); 1330 release_last_reference_callstack_ = base::debug::StackTrace();
1329 1331
1330 shutting_down_ = true; 1332 shutting_down_ = true;
1331 #if BUILDFLAG(ENABLE_PRINTING) 1333 #if BUILDFLAG(ENABLE_PRINTING)
1332 // Wait for the pending print jobs to finish. Don't do this later, since 1334 // Wait for the pending print jobs to finish. Don't do this later, since
1333 // this might cause a nested message loop to run, and we don't want pending 1335 // this might cause a nested message loop to run, and we don't want pending
1334 // tasks to run once teardown has started. 1336 // tasks to run once teardown has started.
1335 print_job_manager_->Shutdown(); 1337 print_job_manager_->Shutdown();
1336 #endif 1338 #endif
1337 1339
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
1413 } 1415 }
1414 1416
1415 void BrowserProcessImpl::OnAutoupdateTimer() { 1417 void BrowserProcessImpl::OnAutoupdateTimer() {
1416 if (CanAutorestartForUpdate()) { 1418 if (CanAutorestartForUpdate()) {
1417 DLOG(WARNING) << "Detected update. Restarting browser."; 1419 DLOG(WARNING) << "Detected update. Restarting browser.";
1418 RestartBackgroundInstance(); 1420 RestartBackgroundInstance();
1419 } 1421 }
1420 } 1422 }
1421 1423
1422 #endif // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS) 1424 #endif // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698