third_party/WebKit/LayoutTests/fast/text/whitespace-text-nodes-float.html - Issue 2719713002: Simplify whitespace layout object creation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text/whitespace-text-nodes-float.html

Issue 2719713002: Simplify whitespace layout object creation.

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 .f {

	4 float: left;

	5 }

	6 </style>

	7 <p id="p"></p>

	8 <script>

	9 window.onload = function (e) {

	10 var p = document.getElementById('p');

	11 p.innerHTML = 'a<span class="f">x</span> <span class="f">y</span >b';
	rune 2017/02/27 10:38:06 I don't think you're guaranteed that you have gene I don't think you're guaranteed that you have generated a layout tree on onload? Are you trying to test (re-)attachment of the p descendants given that p already has a box? You should have a better pass condition. For instance: "SS<span>P</span> <span>A</span>PASS" with a preceding: "<p>You should see the word PASS two times below.</p>". Also, what would typically break is the case where you don't re-attach all siblings, for instance going from block to float where you didn't have a whitespace layout object, but needs one after changing the display type to float. emilio 2017/02/27 12:09:32 This is literally a copy-pasted test case from htt Show quoted text On 2017/02/27 10:38:06, rune wrote: > I don't think you're guaranteed that you have generated a layout tree on onload? > Are you trying to test (re-)attachment of the p descendants given that p already > has a box? > > You should have a better pass condition. For instance: "SS<span>P</span> > <span>A</span>PASS" > with a preceding: "<p>You should see the word PASS two times below.</p>". > > Also, what would typically break is the case where you don't re-attach all > siblings, for instance going from block to float where you didn't have a > whitespace layout object, but needs one after changing the display type to > float. This is literally a copy-pasted test case from https://bugs.chromium.org/p/chromium/issues/detail?id=556733, which is what introduced https://chromium.googlesource.com/chromium/src.git/+/2748c5cea72b053e64920d9b..., but yeah, I'll add more test cases with better passing conditions.
	12 };

	13 </script>

OLD	NEW