Issue 2719703005: fix dartanalyzer find options in bazel workspace

Issue 2719703005: fix dartanalyzer find options in bazel workspace (Closed)

Created:
3 years, 9 months ago by danrubel

Modified:
3 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

fix dartanalyzer find options in bazel workspace - add dartanalyzer test for bazel workspace - ensure call to getAnalysisOptions passes an absolute path - update BasicWorkspace to have an absolute normalized path similar to BazelWorkspace R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c04f6a2ab10a01d58d3371ea1bffe3cbfb4b9955

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -22 lines)			Patch
M	pkg/analyzer/lib/src/context/builder.dart	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/driver.dart	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	pkg/analyzer_cli/test/analysis_options_test.dart	View	2 chunks	+5 lines, -16 lines	0 comments	Download
A	pkg/analyzer_cli/test/data/bazel/WORKSPACE	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	pkg/analyzer_cli/test/data/bazel/proj/lib/file.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer_cli/test/driver_test.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	pkg/analyzer_cli/test/utils.dart	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

danrubel

3 years, 9 months ago (2017-02-26 16:53:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c04f6a2ab10a01d58d3371ea1bffe3cbfb4b9955 (presubmit successful).