Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 27197012: Add better error messages to the webkit_tests step in the android buildbot code. (Closed)

Created:
7 years, 2 months ago by Dirk Pranke
Modified:
7 years, 2 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Add better error messages to the webkit_tests step in the android buildbot code. R=ilevy@google.com, ilevy@chromium.org, peter@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
7 years, 2 months ago (2013-10-17 02:21:25 UTC) #1
Isaac (use chromium)
lgtm
7 years, 2 months ago (2013-10-17 02:57:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/27197012/1
7 years, 2 months ago (2013-10-17 17:35:51 UTC) #3
Dirk Pranke
Committed patchset #1 manually as r229193.
7 years, 2 months ago (2013-10-17 18:57:20 UTC) #4
Dirk Pranke
landed directly ... ilevy lgtm'ed the change, but from the wrong account. I skipped the ...
7 years, 2 months ago (2013-10-17 18:58:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31058
7 years, 2 months ago (2013-10-17 19:28:55 UTC) #6
Isaac (away)
7 years, 2 months ago (2013-10-17 20:05:23 UTC) #7
Message was sent while issue was closed.
On 2013/10/17 19:28:55, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Sorry about that.

Interestingly, CQ has a mapping of chromium<->google, so a committer LGTM works
from either account.  But not for owners unless both emails are explicitly
listed. le sigh

Powered by Google App Engine
This is Rietveld 408576698