Issue 27197004: Move renderer plugin code into a new component (re-land)

Issue 27197004: Move renderer plugin code into a new component (re-land) (Closed)

Created:
7 years, 2 months ago by aberent

Modified:
7 years, 2 months ago

Reviewers:
Bernhard Bauer, darin (slow to review), Jói

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move renderer plugin code into a new component (re-land) Android Webview needs to use some of the renderer plugin code, however this code is currently in chrome. This commit moves the parts of this code that don't depend on the rest of chrome into a new component. This is a new commit of https://codereview.chromium.org/23606022 which had to be reverted due to a use after free problem, now fixed. The only change from the previous CL is to chrome_plugin_placeholder.cc so TBR'ing owners of other files. TBR=darin@chromium.org, joi@chromium.org BUG=283713, 306815, 306803 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228900

Patch Set 1 #

Patch Set 2 : Move renderer plugin code into a new component (re-land) - fix use after free #

Total comments: 3

Patch Set 3 : Move renderer plugin code into a new component (re-land) - fix nit and rebase #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1179 lines, -1331 lines)			Patch
M	chrome/chrome_renderer.gypi	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/renderer/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 2	11 chunks	+82 lines, -27 lines	0 comments	Download
A	chrome/renderer/plugins/chrome_plugin_placeholder.h	View		1 chunk	+103 lines, -0 lines	0 comments	Download
A	chrome/renderer/plugins/chrome_plugin_placeholder.cc	View	1 2	1 chunk	+360 lines, -0 lines	0 comments	Download
D	chrome/renderer/plugins/plugin_placeholder.h	View		1 chunk	+0 lines, -193 lines	0 comments	Download
D	chrome/renderer/plugins/plugin_placeholder.cc	View	1 2	1 chunk	+0 lines, -626 lines	0 comments	Download
M	chrome/renderer/plugins/plugin_uma.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/plugins/plugin_uma.cc	View		3 chunks	+14 lines, -31 lines	0 comments	Download
M	chrome/renderer/plugins/plugin_uma_unittest.cc	View		4 chunks	+8 lines, -12 lines	0 comments	Download
D	chrome/renderer/plugins/webview_plugin.h	View		1 chunk	+0 lines, -154 lines	0 comments	Download
D	chrome/renderer/plugins/webview_plugin.cc	View		1 chunk	+0 lines, -233 lines	0 comments	Download
M	components/components.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/components_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
A	components/plugins.gypi	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A +	components/plugins/OWNERS	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	components/plugins/renderer/DEPS	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	components/plugins/renderer/mobile_youtube_plugin.h	View		1 chunk	+41 lines, -0 lines	0 comments	Download
A	components/plugins/renderer/mobile_youtube_plugin.cc	View	1 2	1 chunk	+113 lines, -0 lines	0 comments	Download
A	components/plugins/renderer/plugin_placeholder.h	View		1 chunk	+115 lines, -0 lines	0 comments	Download
A	components/plugins/renderer/plugin_placeholder.cc	View		1 chunk	+247 lines, -0 lines	0 comments	Download
A +	components/plugins/renderer/webview_plugin.h	View		5 chunks	+14 lines, -13 lines	0 comments	Download
A +	components/plugins/renderer/webview_plugin.cc	View		7 chunks	+25 lines, -34 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM https://codereview.chromium.org/27197004/diff/1024/components/plugins.gypi File components/plugins.gypi (right): https://codereview.chromium.org/27197004/diff/1024/components/plugins.gypi#newcode22 components/plugins.gypi:22: 'plugins/renderer/plugin_placeholder.cc', Note: If all the code in this ...

7 years, 2 months ago (2013-10-15 19:11:50 UTC) #2

Bernhard Bauer

LGTM with a nit: https://codereview.chromium.org/27197004/diff/1024/chrome/renderer/plugins/chrome_plugin_placeholder.cc File chrome/renderer/plugins/chrome_plugin_placeholder.cc (right): https://codereview.chromium.org/27197004/diff/1024/chrome/renderer/plugins/chrome_plugin_placeholder.cc#newcode72 chrome/renderer/plugins/chrome_plugin_placeholder.cc:72: render_view()->CancelContextMenu(context_menu_request_id_); Nit: newline afterwards for ...

7 years, 2 months ago (2013-10-15 19:43:21 UTC) #3

aberent

https://codereview.chromium.org/27197004/diff/1024/chrome/renderer/plugins/chrome_plugin_placeholder.cc File chrome/renderer/plugins/chrome_plugin_placeholder.cc (right): https://codereview.chromium.org/27197004/diff/1024/chrome/renderer/plugins/chrome_plugin_placeholder.cc#newcode72 chrome/renderer/plugins/chrome_plugin_placeholder.cc:72: render_view()->CancelContextMenu(context_menu_request_id_); On 2013/10/15 19:43:21, Bernhard Bauer wrote: > Nit: ...

7 years, 2 months ago (2013-10-16 09:47:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/27197004/14001

7 years, 2 months ago (2013-10-16 09:48:17 UTC) #5

Message was sent while issue was closed.

Change committed as 228900

Expand Messages | Collapse Messages