Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2719603002: Rename Closure instance field type_arguments_ to instantiator_. (Closed)
Patch Set: work in progress Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 812af17f2a6c4d5b25fcc23ba3cc2a86641ba564..219afeaaf0a77b8857a9dc006bd3ec6516b5d6c7 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -1705,10 +1705,11 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
Label loop, found, not_found, next_iteration;
// EDX: Entry start.
// ECX: instance class id.
- // EBX: instance type arguments.
+ // EBX: instance type arguments (still null if closure).
__ SmiTag(ECX);
__ cmpl(ECX, Immediate(Smi::RawValue(kClosureCid)));
__ j(NOT_EQUAL, &loop, Assembler::kNearJump);
+ __ movl(EBX, FieldAddress(EAX, Closure::instantiator_offset()));
__ movl(ECX, FieldAddress(EAX, Closure::function_offset()));
// ECX: instance class id as Smi or function.
__ Bind(&loop);
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698