Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: runtime/vm/raw_object.h

Issue 2719603002: Rename Closure instance field type_arguments_ to instantiator_. (Closed)
Patch Set: work in progress Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 54a2df28433777455c2c40dd1e4612b2a0171969..85cebf5ffae146ed54d557c3b89cf17243c84f17 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -1782,10 +1782,14 @@ class RawClosure : public RawInstance {
RAW_HEAP_OBJECT_IMPLEMENTATION(Closure);
RawObject** from() {
- return reinterpret_cast<RawObject**>(&ptr()->type_arguments_);
+ return reinterpret_cast<RawObject**>(&ptr()->instantiator_);
}
- RawTypeArguments* type_arguments_;
+ // No instance fields should be declared before the following 3 fields whose
+ // offsets must be identical in Dart and C++.
+
+ // These 3 fields are also declared in the Dart source of class _Closure.
+ RawTypeArguments* instantiator_;
RawFunction* function_;
RawContext* context_;
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/simulator_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698